Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5915: Delete search filters that are not needed anymore #2191

Merged

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Jan 27, 2025

Description

Delete deprecated fields and filters.

  • Comments
  • comment_counts
  • rules
  • project_id

References: CV2-5915

How has this been tested?

Re-run automated tests.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@melsawy melsawy marked this pull request as ready for review February 2, 2025 16:08
Copy link

codeclimate bot commented Feb 2, 2025

Code Climate has analyzed commit 7c15799 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see these many deleted lines! But @melsawy , please make sure that integration tests also pass before merging, please.

@melsawy
Copy link
Contributor Author

melsawy commented Feb 3, 2025

Nice to see these many deleted lines! But @melsawy , please make sure that integration tests also pass before merging, please.

Sure Caio already I run all tests here meedan/check-web#2275

@melsawy melsawy merged commit 31039ea into develop Feb 3, 2025
16 checks passed
@melsawy melsawy deleted the CV2-5915-delete-search-filters-that-are-not-needed-anymore branch February 3, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants