Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the format of the tipline message for the Civic API integration. #2118

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Updating the format of the tipline message for the Civic API integration. #2118

merged 1 commit into from
Nov 1, 2024

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Nov 1, 2024

Description

Adding emojis and also showing the date/hours information.

Reference: CV2-5456.

How has this been tested?

Captura de tela de 2024-10-31 22-56-32

Things to pay attention to during code review

This is a prototype feature. It's behind a feature flag.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@caiosba
Updating the format of the tipline message of the Civic API integration.
6ff6487 
Adding emojis and also showing the date/hours information.

Reference: CV2-5456.
jayjay-w
jayjay-w approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@jayjay-w jayjay-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caiosba caiosba merged commit 13494b5 into develop Nov 1, 2024
11 checks passed
@caiosba caiosba deleted the fix/CV2-5456-civic-api-integration-formatting-update branch November 1, 2024 13:59
caiosba added a commit that referenced this pull request Nov 1, 2024
@caiosba
Updating the format of the tipline message of the Civic API integrati…
d8b68ff 
…on. (#2118)

Adding emojis and also showing the date/hours information.

Reference: CV2-5456.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjay-w jayjay-w jayjay-w approved these changes

@melsawy melsawy Awaiting requested review from melsawy melsawy is a code owner

@DGaffney DGaffney Awaiting requested review from DGaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caiosba @jayjay-w