Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5050 readd target_field value from broken case for text #2117

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

DGaffney
Copy link
Contributor

Description

Right now we have a lingering issue where relationships are being persisted without target_field - the root of the error is that for text, the field is wrapped inside the context parameter (and in fact... may always be there?). Quick fix to address that.

References: CV2-5050

How has this been tested?

Tested locally against cached data persisted on Bot::Alegre.process_alegre_callback(params) and confirmed to work.

Things to pay attention to during code review

None in particular!

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that it's a resilient solution

Copy link

codeclimate bot commented Oct 31, 2024

Code Climate has analyzed commit 0b6b41a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 99.9%.

View more on Code Climate.

@DGaffney DGaffney marked this pull request as ready for review October 31, 2024 20:30
@DGaffney DGaffney merged commit df7597f into develop Oct 31, 2024
16 checks passed
@DGaffney DGaffney deleted the cv2-5050-fix-target-field branch October 31, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants