Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team statistics by rating should return the rating ID, not the label. #2113

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Oct 30, 2024

Description

This way, the API client can manipulate it better, for example, translate to another language or get the color associated with it.

Reference: CV2-5389.

How has this been tested?

Automated test updated to cover these changes.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

This way, the API client can manipulate it better, for example, translate to another language or get the color associated with it.

Reference: CV2-5389.
@caiosba caiosba merged commit 28107ea into develop Oct 30, 2024
11 checks passed
@caiosba caiosba deleted the fix/CV2-5389-statistics-by-rating-returns-id branch October 30, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants