Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5558: Downgrade based on last_seen, not created_at; add better logging #2110

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

computermacgyver
Copy link
Contributor

@computermacgyver computermacgyver commented Oct 30, 2024

Description

Better log when and why a relationship is downgraded from a confirmed match to a suggestion. When downgrading for an "old" match, use last_seen, not created_at

References: CV2-5558

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@computermacgyver computermacgyver marked this pull request as ready for review October 30, 2024 08:49
@caiosba
Copy link
Contributor

caiosba commented Oct 30, 2024

@computermacgyver if you need help to fix this test, please let us know: Bot::AlegreTest#test_should_set_similarity_relationship_based_on_date_threshold [/app/test/models/bot/alegre_test.rb:204].

@computermacgyver computermacgyver force-pushed the CV2-5558-last-seen-relationships branch from 283f730 to 0809c58 Compare November 4, 2024 11:05
@computermacgyver computermacgyver force-pushed the CV2-5558-last-seen-relationships branch from 0809c58 to bfa87ad Compare November 4, 2024 13:54
@computermacgyver computermacgyver merged commit 4629593 into develop Nov 4, 2024
11 checks passed
@computermacgyver computermacgyver deleted the CV2-5558-last-seen-relationships branch November 4, 2024 16:41
caiosba pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants