Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5301: add a report published_at to CSV export file #2099

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Oct 20, 2024

Description

  • Change Published at column label to Social Media Posted at
  • Add column Report Published at

References: CV2-5301

How has this been tested?

Re-run automated tests.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Sawy. Let's keep an eye to see if, for big exports, storing pm_report in memory will be an issue. If so, we can load this information one by one, since it runs in background anyway.

@melsawy melsawy merged commit 425235f into develop Oct 21, 2024
11 checks passed
@melsawy melsawy deleted the CV2-5301-data-exports-include-published-at-dates-that-are-misleading branch October 21, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants