Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling for unblock_user method #1793

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Feb 7, 2024

Description

When trying to unblock a tipline user, don't crash if there is no related instance in the blocked_tipline_users table.

How has this been tested?

Existing tests should cover this.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link

codeclimate bot commented Feb 7, 2024

Code Climate has analyzed commit 6ba2270 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@caiosba caiosba merged commit fdbabff into develop Feb 7, 2024
8 checks passed
@caiosba caiosba deleted the fix/unblock-user branch February 7, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants