Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore flaky tests (user lock/unlock) #1792

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jayjay-w
Copy link
Contributor

@jayjay-w jayjay-w commented Feb 6, 2024

These two tests are behaving erratically on CI, so we are commenting them out while we debug the issue.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context – why has this been changed/fixed.

References: CV2-4164

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

Confirm that no unintended tests have been removed.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

These two tests are behaving erratically on CI, so we are commenting
them out while we debug the issue.
Copy link

codeclimate bot commented Feb 6, 2024

Code Climate has analyzed commit 3383c63 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

@jayjay-w jayjay-w marked this pull request as ready for review February 6, 2024 18:39
@jayjay-w jayjay-w merged commit ebe1d95 into develop Feb 6, 2024
8 checks passed
@jayjay-w jayjay-w deleted the CV2-4164-fix-unlock-account-flaky-test-b branch March 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants