Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test in sessions_controller_test.rb #1790

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

jayjay-w
Copy link
Contributor

@jayjay-w jayjay-w commented Feb 2, 2024

Description

Testing devise's lock/unlock strategy is misbehaving in during CI runs.

References: CV2-4163

How has this been tested?

Ensured that rate limit checks are working

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

Ensure that all rate limit tests are passing.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

jayjay-w and others added 2 commits February 2, 2024 18:56
Copy link

codeclimate bot commented Feb 5, 2024

Code Climate has analyzed commit 2b3f9ab and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@jayjay-w jayjay-w marked this pull request as ready for review February 5, 2024 14:55
@jayjay-w jayjay-w merged commit ac90eff into develop Feb 5, 2024
8 checks passed
@jayjay-w jayjay-w deleted the CV2-4164-fix-unlock-account-flaky-test branch March 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants