-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CV2-4233 add retry looper for alegre requests that intermittently fail #1786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions and one request - also, tests must pass - good to go after that! :)
Code Climate has analyzed commit 436d10f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
@caiosba ran into some slightly weird speedbumps yesterday but back to full passage - lemme know if you need anything else before signoff! |
#1786) * CV2-4233 add retry looper for alegre requests that intermittently fail * CV2-4233 fix fixture * update test with right params * change blah to proper type * update function based on it being a hash that's actually being passed around * refactors from PR * add stub * fix typo
Description
When running via smooch, every once in a while, a request from Check-API to Alegre fails. There is every indication that this is some sort of intermittent, non-serious issue. When trying to reproduce them, even at large scales with lots of attempts to recreate the issue, Alegre responds correctly consistently. When looking at Alegre and Presto, neither show any indication that there is an issue. The response itself doesn't seem to be loud or fundamentally broken. For the time being, we're introducing a retry - and if that fails, we'll be much more confident that something more fundamental is happening that requires a deeper dive.
References: CV2-4233
How has this been tested?
I've added a direct test that should yield a proper null output after retrying multiple times, and ran a local script with side-effecting printouts to ensure it is doing what is intended.
Things to pay attention to during code review
Nothing really - fairly straightforward retry cycle
Checklist