Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change devise unlock strategy from :both to :time #1785

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

jayjay-w
Copy link
Contributor

Description

Currently, we are using an unlock strategy of :both, which allows both time based unlocking and email based unlocking. This leads to an email being sent to the user when their account is locked, which us currently not intended.

References: CV2-4164

How has this been tested?

Confirmed that all tests are passing

Things to pay attention to during code review

Ensure that locking and unlocking of user accounts works as expected.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Currently, we are using an unlock strategy of `:both`, which allows
both time based unlocking and email based unlocking. This leadds to
an email being sent to the user when their account is locked, which
us currently not intended.
Copy link

codeclimate bot commented Jan 29, 2024

Code Climate has analyzed commit db7f042 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.9% (0.0% change).

View more on Code Climate.

@jayjay-w jayjay-w marked this pull request as ready for review January 29, 2024 20:26
@jayjay-w jayjay-w merged commit f77015b into develop Jan 29, 2024
8 checks passed
@jayjay-w jayjay-w deleted the CV2-4164-change_devise_unlock_strategy branch March 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants