Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the set_cluster method definition and calls from Alegre Bot #1784

Merged

Conversation

jayjay-w
Copy link
Contributor

@jayjay-w jayjay-w commented Jan 25, 2024

For FactsFirstPH, elections project we run in the Philippines in early 2022, we implemented the very first version of shared feeds and global clusters. Part of that logic included adding new items to clusters automatically. We’re changing this logic, so before proceeding with the new logic, it’s important to get rid of the previous one.

Description

References: CV2-4173

How has this been tested?

Confirmed that all tests pass locally.

Things to pay attention to during code review

Confirm that all removed methods are no longer needed.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@jayjay-w jayjay-w force-pushed the CV2-4173-Nix-deprecated-clustering-logic-from-Check-API branch 4 times, most recently from fee2257 to 5edf100 Compare January 29, 2024 21:50
For FactsFirstPH, elections project we run in the Philippines in early 2022, we implemented the very first version of shared feeds and global clusters. Part of that logic included adding new items to clusters automatically. We’re changing this logic, so before proceeding with the new logic, it’s important to get rid of the previous one.
@jayjay-w jayjay-w force-pushed the CV2-4173-Nix-deprecated-clustering-logic-from-Check-API branch from 5edf100 to a5c4bdb Compare January 31, 2024 12:55
Copy link

codeclimate bot commented Jan 31, 2024

Code Climate has analyzed commit a5c4bdb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@jayjay-w jayjay-w marked this pull request as ready for review January 31, 2024 16:43
@jayjay-w jayjay-w merged commit 8b434d7 into develop Jan 31, 2024
8 checks passed
@jayjay-w jayjay-w deleted the CV2-4173-Nix-deprecated-clustering-logic-from-Check-API branch March 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants