Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test in SessionsControllerTest #1782

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

jayjay-w
Copy link
Contributor

There is a failing test in SessionsController where travel_to is behaving differently in CI vs dev. This PR contains a fix for it.

Description

In #1777, a new test was introduced in SessionsControllerTest, but it is bugging out in CI.

References: CV2-4164

How has this been tested?

Verified that the test passes successfully.

Things to pay attention to during code review

Run: rails test test/controllers/sessions_controller_test.rb:88

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

There is a failing test in SessionsController where travel_to is
behaving differently in CI vs dev. This PR contains a fix for it.
@jayjay-w jayjay-w force-pushed the CV2-4164-Fix-Unlock-User-Test branch from 6001d2f to 0290f89 Compare January 25, 2024 08:56
Copy link

codeclimate bot commented Jan 25, 2024

Code Climate has analyzed commit 0290f89 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

@jayjay-w jayjay-w marked this pull request as ready for review January 25, 2024 11:11
@jayjay-w jayjay-w merged commit 5a16fd6 into develop Jan 25, 2024
8 checks passed
@jayjay-w jayjay-w deleted the CV2-4164-Fix-Unlock-User-Test branch March 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants