Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate column picker settings page #1771

Conversation

danielevalverde
Copy link
Collaborator

Description

Delete the GraphQL field list_columns from TeamType, delete the respective model method and any other dependent code and related tests

Reference: CV2-3920

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Delete the GraphQL field list_columns from TeamType, delete the respective model method and any other dependent code and related tests

Reference: CV2-3920
…2-3920-deprecate-column-picker-settings-page
@danielevalverde danielevalverde marked this pull request as draft January 4, 2024 16:02
@danielevalverde danielevalverde changed the title Deprecate column picker settings page [DRAFT!!] [WIP] Deprecate column picker settings page [WIP] Jan 12, 2024
@danielevalverde danielevalverde changed the base branch from develop to epic/cv2-3939-replace-table-view-with-cards June 12, 2024 14:56
@danielevalverde danielevalverde changed the title [WIP] Deprecate column picker settings page [WIP] Deprecate column picker settings page Jun 12, 2024
@danielevalverde danielevalverde marked this pull request as ready for review June 12, 2024 14:56
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo deleted lines! Good to go if tests pass (including integration tests on the respective Check Web branch).

@danielevalverde danielevalverde removed the request for review from jayjay-w June 12, 2024 15:29
DGaffney and others added 3 commits June 12, 2024 15:50
* CV2-4741 increase timeout from one to two minutes

* add CheckConfig for sleep timer
…2-3920-deprecate-column-picker-settings-page
@danielevalverde danielevalverde merged commit a44976c into epic/cv2-3939-replace-table-view-with-cards Jun 13, 2024
2 checks passed
@danielevalverde danielevalverde deleted the feature/CV2-3920-deprecate-column-picker-settings-page branch June 13, 2024 20:40
danielevalverde added a commit that referenced this pull request Jul 4, 2024
* Expose projectMedia.fact_check_published_on field

* create epic brach

* Deprecate column picker settings page (#1771)

* Deprecate column picker settings page

Delete the GraphQL field list_columns from TeamType, delete the respective model method and any other dependent code and related tests

Reference: CV2-3920

Co-authored-by: Alexandre Amorim <[email protected]>
Co-authored-by: Brian Fleming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants