-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate column picker settings page #1771
Merged
danielevalverde
merged 7 commits into
epic/cv2-3939-replace-table-view-with-cards
from
feature/CV2-3920-deprecate-column-picker-settings-page
Jun 13, 2024
Merged
Deprecate column picker settings page #1771
danielevalverde
merged 7 commits into
epic/cv2-3939-replace-table-view-with-cards
from
feature/CV2-3920-deprecate-column-picker-settings-page
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete the GraphQL field list_columns from TeamType, delete the respective model method and any other dependent code and related tests Reference: CV2-3920
…2-3920-deprecate-column-picker-settings-page
…2-3920-deprecate-column-picker-settings-page
caiosba
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooo deleted lines! Good to go if tests pass (including integration tests on the respective Check Web branch).
* CV2-4741 increase timeout from one to two minutes * add CheckConfig for sleep timer
…2-3920-deprecate-column-picker-settings-page
a44976c
into
epic/cv2-3939-replace-table-view-with-cards
2 checks passed
danielevalverde
added a commit
that referenced
this pull request
Jul 4, 2024
* Expose projectMedia.fact_check_published_on field * create epic brach * Deprecate column picker settings page (#1771) * Deprecate column picker settings page Delete the GraphQL field list_columns from TeamType, delete the respective model method and any other dependent code and related tests Reference: CV2-3920 Co-authored-by: Alexandre Amorim <[email protected]> Co-authored-by: Brian Fleming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delete the GraphQL field list_columns from TeamType, delete the respective model method and any other dependent code and related tests
Reference: CV2-3920
Checklist