CV2-6038: apply PR comments

meedan · Feb 10, 2025 · 54a73cf · 54a73cf
1 parent 8980b8d
commit 54a73cf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/app/models/concerns/project_media_getters.rb b/app/models/concerns/project_media_getters.rb
@@ -214,9 +214,9 @@ def fact_check
     self.claim_description&.fact_check
   end
 
-  def explainers_title
-    # Get the title for all explainer assinged to the item
-    titles = Explainer.joins(:explainer_items).where('explainer_items.project_media_id = ?', self.id).map(&:title).join(' ')
+  def explainers_titles
+    # Get the title for all explainer assigned to the item
+    titles = Explainer.joins(:explainer_items).where('explainer_items.project_media_id = ?', self.id).map(&:title).join("\n")
     titles.blank? ? nil : titles
   end
 end
diff --git a/app/models/explainer_item.rb b/app/models/explainer_item.rb
@@ -35,7 +35,7 @@ def update_elasticsearch_data
       pm.update_columns(updated_at: updated_at)
       data = { updated_at: updated_at.utc }
       data['explainer_title'] = {
-        method: "explainers_title",
+        method: "explainers_titles",
         klass: pm.class.name,
         id: pm.id,
         default: nil,

diff --git a/lib/tasks/migrate/20250205224319_add_mapping_for_explainer_title_field.rake b/lib/tasks/migrate/20250205224319_add_mapping_for_explainer_title_field.rake
@@ -9,8 +9,7 @@ namespace :check do
         next if skip_pmids.include?(raw.project_media_id)
         pm = raw.project_media
         doc_id =  Base64.encode64("ProjectMedia/#{pm.id}")
-        explainers_title = pm.explainers_title
-        fields = { 'explainer_title' => pm.explainers_title }
+        fields = { 'explainer_title' => pm.explainers_titles }
         es_body << { update: { _index: index_alias, _id: doc_id, retry_on_conflict: 3, data: { doc: fields } } }
         skip_pmids << pm.id
       end