Adding tests and fixing CC issues

app/lib/smooch_nlu.rb

@@ -64,9 +64,6 @@ def self.disambiguation_threshold
   def self.alegre_matches_from_message(message, language, context, alegre_result_key, uid)
     # FIXME: Raise exception if not in a tipline context (so, if Bot::Smooch.config is nil)
     matches = []
-    team_slug = Team.find(Bot::Smooch.config['team_id']).slug
-    params = nil
-    response = nil
     unless Bot::Smooch.config.to_h['nlu_enabled']
       return []
     end
@@ -80,6 +77,7 @@ def self.alegre_matches_from_message(message, language, context, alegre_result_k
     end
     begin
       self.increment_global_counter
+      team_slug = Team.find(Bot::Smooch.config['team_id']).slug
       # FIXME: In the future we could consider matches across all languages when options is nil
       # FIXME: No need to call Alegre if it's an exact match to one of the keywords
       # FIXME: No need to call Alegre if message has no word characters

test/lib/smooch_nlu_test.rb

@@ -122,4 +122,29 @@ def create_team_with_smooch_bot_installed
     Bot::Smooch.get_installation('smooch_id', 'test')
     assert_not_nil SmoochNlu.menu_options_from_message('I want to subscribe to the newsletter', 'en', @menu_options, random_string)
   end
+
+  test 'should return empty list of matches if global rate limit is reached' do
+    Bot::Smooch.stubs(:config).returns({ 'nlu_enabled' => true })
+    Bot::Alegre.stubs(:request).never
+    SmoochNlu.increment_global_counter
+    SmoochNlu.increment_global_counter
+    stub_configs({ 'nlu_global_rate_limit' => 1 }) do
+      assert_equal [], SmoochNlu.alegre_matches_from_message('test', 'en', {}, 'test', 'test')
+    end
+  end
+
+  test 'should return empty list of matches if user rate limit is reached' do
+    Bot::Smooch.stubs(:config).returns({ 'nlu_enabled' => true })
+    Bot::Alegre.stubs(:request).never
+    2.times { create_tipline_message uid: '123', state: 'received' }
+    stub_configs({ 'nlu_user_rate_limit' => 1 }) do
+      assert_equal [], SmoochNlu.alegre_matches_from_message('test', 'en', {}, 'test', '123')
+    end
+  end
+
+  test 'should return empty list of matches if exception happens' do
+    Bot::Smooch.stubs(:config).returns({ 'nlu_enabled' => true })
+    Bot::Alegre.stubs(:request).never
+    assert_equal [], SmoochNlu.alegre_matches_from_message('test', 'en', {}, 'test', 'test')
+  end
 end