refactors from PR

meedan · Jan 30, 2024 · 1900350 · 1900350
1 parent 14f8b53
commit 1900350
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/app/models/concerns/alegre_v2.rb b/app/models/concerns/alegre_v2.rb
@@ -234,7 +234,7 @@ def parse_similarity_results(project_media, field, results, relationship_type)
     def safe_get_sync(project_media, field, params={})
       response = get_sync(project_media, field, params)
       retries = 0
-      while (response == nil or response["result"] == nil) and retries < 3
+      while (response.nil? || response["result"].nil?) && retries < 3
         response = get_sync(project_media, field, params)
         retries += 1
       end

diff --git a/test/models/bot/alegre_v2_test.rb b/test/models/bot/alegre_v2_test.rb
@@ -285,9 +285,8 @@ def teardown
 
   test "should safe_get_sync" do
     pm1 = create_project_media team: @team, media: create_uploaded_audio
-    response = {}
-    WebMock.stub_request(:post, "#{CheckConfig.get('alegre_host')}/similarity/sync/audio").with(body: {:doc_id=>Bot::Alegre.item_doc_id(pm1), :context=>{:team_id=>pm1.team_id, :project_media_id=>pm1.id, :has_custom_id=>true}, :url=>Bot::Alegre.media_file_url(pm1)}).to_return(body: response.to_json)
-    assert_equal Bot::Alegre.safe_get_sync(pm1, "audio", {}), {}
+    WebMock.stub_request(:post, "#{CheckConfig.get('alegre_host')}/similarity/sync/audio").to_return(body: '{}')
+    assert_equal {}, Bot::Alegre.safe_get_sync(pm1, "audio", {})
   end
 
   test "should run delete request" do