-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard,core-flows,types,utils,medusa): Order cancelations will refund payments #10667
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
🦋 Changeset detectedLatest commit: b226570 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e31b3c4
to
4abf68b
Compare
Hey @olivermrbl, shall we wrap this project up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, few comments and nits
difference_sum: 30, | ||
current_order_total: 0, | ||
pending_difference: 0, | ||
difference_sum: 0, | ||
paid_total: 0, | ||
refunded_total: 0, | ||
credit_line_total: 30, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: On line 98-104, we had another credit line manually to the order–why is that? Is it to assert that the totals are going into the negatives?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily negative. Its to test if existing credit lines from the order is being taken into account before adding more from the current action. between versions, the credit_lines array will change depending on actions.
what:
RESOLVES CMRC-797
RESOLVES CMRC-798
RESOLVES CMRC-799