-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core-flow): invalid update quantity in update line item in cart workflow #10405
fix(core-flow): invalid update quantity in update line item in cart workflow #10405
Conversation
|
Someone is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
…item-in-cart-workflow
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @daykrm
…item-in-cart-workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, appreciate the contribution
…item-in-cart-workflow
…item-in-cart-workflow
@daykrm, can you look into the failing test? |
sure, I'll take a look |
this should already work @olivermrbl |
@olivermrbl Hi, could you please review this PR again? We’re currently blocked. Thank you. |
…item-in-cart-workflow
packages/core/core-flows/src/cart/workflows/update-line-item-in-cart.ts
Outdated
Show resolved
Hide resolved
This PR currently has a merge conflict. Please resolve this and then re-add the |
@daykrm, any chance you can resolve the conflicts, so we can get it merged? 🙏 |
I fixed the PR conflict. Please take another look. @olivermrbl |
What
Use 'quantity' from request instead of cart item's quantity in
updateLineItemInCartWorkflow
Why
To resolve the issue where users can update line item quantities exceeding stock levels
CLOSES SUP-542