Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-flow): invalid update quantity in update line item in cart workflow #10405

Conversation

daykrm
Copy link
Contributor

@daykrm daykrm commented Dec 3, 2024

What
Use 'quantity' from request instead of cart item's quantity in updateLineItemInCartWorkflow
Why
To resolve the issue where users can update line item quantities exceeding stock levels

CLOSES SUP-542

@daykrm daykrm requested a review from a team as a code owner December 3, 2024 08:58
Copy link

changeset-bot bot commented Dec 3, 2024

⚠️ No Changeset found

Latest commit: 2e2cac5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 3, 2024

Someone is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:24pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 11:24pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 11:24pm

Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @daykrm

@fPolic fPolic requested a review from olivermrbl December 6, 2024 07:30
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, appreciate the contribution

@olivermrbl
Copy link
Contributor

@daykrm, can you look into the failing test?

@daykrm
Copy link
Contributor Author

daykrm commented Dec 9, 2024

@daykrm, can you look into the failing test?

sure, I'll take a look

@daykrm daykrm closed this Dec 9, 2024
@daykrm daykrm reopened this Dec 9, 2024
@daykrm
Copy link
Contributor Author

daykrm commented Dec 9, 2024

this should already work @olivermrbl

@oDestroyeRo
Copy link
Contributor

@olivermrbl Hi, could you please review this PR again? We’re currently blocked. Thank you.

Copy link
Contributor

kodiakhq bot commented Dec 17, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@olivermrbl
Copy link
Contributor

@daykrm, any chance you can resolve the conflicts, so we can get it merged? 🙏

@daykrm
Copy link
Contributor Author

daykrm commented Jan 5, 2025

I fixed the PR conflict. Please take another look. @olivermrbl

@olivermrbl olivermrbl merged commit 79c87c0 into medusajs:develop Jan 5, 2025
15 of 22 checks passed
@daykrm daykrm deleted the fix/invalid-item-quantity-in-update-line-item-in-cart-workflow branch January 6, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants