Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pageSize to EverythingDataSelectorConfig #505

Conversation

trobanga
Copy link
Collaborator

@trobanga trobanga commented Jan 7, 2025

No description provided.

@trobanga trobanga linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (5de852c) to head (bfcf844).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #505      +/-   ##
============================================
+ Coverage     96.16%   96.18%   +0.01%     
- Complexity      412      415       +3     
============================================
  Files           108      108              
  Lines          1537     1545       +8     
  Branches         41       42       +1     
============================================
+ Hits           1478     1486       +8     
  Misses           42       42              
  Partials         17       17              
Files with missing lines Coverage Δ
...are/smith/fts/cda/impl/EverythingDataSelector.java 100.00% <100.00%> (ø)
...ith/fts/cda/impl/EverythingDataSelectorConfig.java 100.00% <100.00%> (ø)
...th/fts/cda/impl/EverythingDataSelectorFactory.java 100.00% <100.00%> (ø)

@trobanga trobanga force-pushed the 500-make-defaultpagesize-in-everythingdataselector-configurable branch 4 times, most recently from 2b51341 to 4ac7972 Compare January 7, 2025 12:10
@trobanga trobanga force-pushed the 500-make-defaultpagesize-in-everythingdataselector-configurable branch from 4ac7972 to bfcf844 Compare January 7, 2025 12:20
@trobanga trobanga enabled auto-merge January 7, 2025 12:25
@trobanga trobanga merged commit b679046 into main Jan 7, 2025
29 checks passed
@trobanga trobanga deleted the 500-make-defaultpagesize-in-everythingdataselector-configurable branch January 7, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make defaultPageSize in EverythingDataSelector configurable
2 participants