Release/v3.1.0 #45
Merged
Release/v3.1.0 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeaDurro
pushed a commit
that referenced
this pull request
Sep 4, 2024
- "Split" DirectBrokerClient into DirectBrokerClientCql and DirectBrokerClientFlare - Add optional result obfuscation for direct broker clients
DeaDurro
pushed a commit
that referenced
this pull request
Sep 4, 2024
- remove unused imports - remove redundant overriding methods - remove unused throws declarations from method signatures - replace IllegalStateException with Checked QueryDefinitionNotFoundException when trying to access a query definition that is not (yet) present - Include filename in error message for missing file - Replace BufferedReader with new String when reading resource file from disk - Suppress unused warning in DirectBrokerClientCqlTest - add logback-test.xml to decrease log level in tests - use QueryMediaType enum instead of Strings where possible - replace creation of new array list with List.copyOf in DirectBrokerClient - remove distinction between local fhir and local cql server and just name them all "Local server" - rename the constant SITE_1_ID to SITE_ID_LOCAL - use random.nextInt with boundaries instead of using - add dummy patients for the DirectBrokerClientCqlIT
DeaDurro
pushed a commit
that referenced
this pull request
Sep 4, 2024
- append "flare" to method name "DirectSpringConfig.directWebClientFlare" to clarify that it is only associated with the flare client - replace custom "internal/json" media type from mock server response in DirectBrokerClientFlareIT and replace it with standard application/json header - replace HashMap with EnumMap in DirectBrokerClient.DirectQuery - rename SITE_1_NAME to SITE_NAME_LOCAL to be consistent with SITE_ID_LOCAL (and make both constants final) - make the fhirClient a local var in the setup method in DirectBrokerClientCqlIT - don't return anything from DirectBrokerClientCqlIT.createDummyPatient - catch and wrap BaseServerResponseException when trying to read measure report from fhir server - catch BaseServerResponseException instead of just FhirClientConnectionException when creating library and measure - throw SiteNotFoundException instead of returning an empty string when the site name for an invalid id is requested - add constructor for QueryDefinitionNotFoundException without QueryMediaType parameter to be thrown in DSFQueryManager, and change the queryMediaType Parameter from String to the respective enum - move Measure.json and Library.json (as well as the 2 cql "query" files) to the direct broker package and use getResourceAsStream - remove backendquery mapping from DirectBrokerClient and move the backendquery id directly to DirectBrokerClient.DirectQuery - extract fhir connection from DirectBrokerClientCql to separate class FhirConnector
DeaDurro
pushed a commit
that referenced
this pull request
Sep 4, 2024
…nable-CQL-in-direct-broker #45 - Enable cql in direct broker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.