[ZARS-669][FIX] fix and run linter

eslint.config.js

@@ -0,0 +1,34 @@
+const tsParser = require('@typescript-eslint/parser');
+const tsEslintPlugin = require('@typescript-eslint/eslint-plugin');
+const prettierPlugin = require('eslint-plugin-prettier');
+const prettierConfig = require('eslint-config-prettier');
+
+module.exports = [
+  {
+    files: ['**/*.ts', '**/*.tsx'], // Apply to TypeScript files
+    languageOptions: {
+      parser: tsParser,
+      parserOptions: {
+        project: './tsconfig.json',
+        sourceType: 'module',
+      },
+    },
+    plugins: {
+      '@typescript-eslint': tsEslintPlugin,
+      prettier: prettierPlugin,
+    },
+    rules: {
+      ...tsEslintPlugin.configs.recommended.rules, // Load recommended TypeScript rules
+      ...prettierConfig.rules, // Load Prettier rules
+      'prettier/prettier': 'error', // Enforce Prettier formatting
+      '@typescript-eslint/interface-name-prefix': 'off',
+      '@typescript-eslint/explicit-function-return-type': 'off',
+      '@typescript-eslint/explicit-module-boundary-types': 'off',
+      '@typescript-eslint/no-explicit-any': 'off',
+    },
+  },
+  {
+    files: ['.eslintrc.js'], // Special handling for config files
+    ignores: [],
+  },
+];

src/modules/auth/__tests__/role.guard.spec.ts

@@ -66,7 +66,7 @@ describe('RoleGuard', () => {
         return { user };
       });
 
-      jest.spyOn(context, 'switchToHttp').mockImplementationOnce(() => ({ getRequest: getRequestMock } as any));
+      jest.spyOn(context, 'switchToHttp').mockImplementationOnce(() => ({ getRequest: getRequestMock }) as any);
       const result = guard.canActivate(context);
       expect(result).toEqual(false);
     });
@@ -82,7 +82,7 @@ describe('RoleGuard', () => {
         return { user };
       });
 
-      jest.spyOn(context, 'switchToHttp').mockImplementationOnce(() => ({ getRequest: getRequestMock } as any));
+      jest.spyOn(context, 'switchToHttp').mockImplementationOnce(() => ({ getRequest: getRequestMock }) as any);
       const result = guard.canActivate(context);
       expect(result).toEqual(true);
     });

src/modules/auth/strategies/jwt.strategy.ts

@@ -9,7 +9,10 @@ import { JwksProvider } from './jwks.provider';
 
 @Injectable()
 export class JwtStrategy extends PassportStrategy(Strategy) {
-  constructor(protected readonly configService: ConfigService, protected readonly jwksProvider: JwksProvider) {
+  constructor(
+    protected readonly configService: ConfigService,
+    protected readonly jwksProvider: JwksProvider,
+  ) {
     super({
       jwtFromRequest: ExtractJwt.fromAuthHeaderAsBearerToken(),
       ignoreExpiration: false,

src/modules/event-engine/events/comments/comment-answer-event.service.ts

@@ -85,7 +85,7 @@ export class CommentAnswerEventService {
   ) {
     const commentLocation = answer.locations.includes(MiiLocation.VirtualAll)
       ? ALL_ACTIVE_LOCATIONS
-      : answer.locations ?? [];
+      : (answer.locations ?? []);
 
     const locations = reduceParticipatingLocations(proposal, commentLocation);
 

src/modules/event-engine/events/comments/comment-event.service.ts

@@ -134,7 +134,7 @@ export class CommentEventService {
   private async handleProposalMessageToLocationCreation(proposal: Proposal, comment: Comment, proposalUrl: string) {
     const commentLocation = comment.locations.includes(MiiLocation.VirtualAll)
       ? ALL_ACTIVE_LOCATIONS
-      : comment.locations ?? [];
+      : (comment.locations ?? []);
 
     const locations = reduceParticipatingLocations(proposal, commentLocation);
 

src/modules/event-engine/events/contracting/contracting.service.ts

@@ -8,7 +8,10 @@ import { getResearcherSignedEmailForDizMembers, getSigningCompleteEmailForFdpgMe
 
 @Injectable()
 export class ContractingService {
-  constructor(private keycloakUtilService: KeycloakUtilService, private emailService: EmailService) {}
+  constructor(
+    private keycloakUtilService: KeycloakUtilService,
+    private emailService: EmailService,
+  ) {}
 
   private async handleResearcherSign(proposal: Proposal, vote: boolean, proposalUrl: string) {
     const emailTasks: Promise<void>[] = [];

src/modules/event-engine/events/location-vote/location-vote.service.ts

@@ -7,7 +7,10 @@ import { getDizApprovalEmailForUacMembers, getVotingCompleteEmailForFdpgMember }
 
 @Injectable()
 export class LocationVoteService {
-  constructor(private keycloakUtilService: KeycloakUtilService, private emailService: EmailService) {}
+  constructor(
+    private keycloakUtilService: KeycloakUtilService,
+    private emailService: EmailService,
+  ) {}
 
   private isVotingComplete(proposal: Proposal): boolean {
     const numberOfVotedLocations = proposal.requestedButExcludedLocations.length + proposal.uacApprovedLocations.length;

src/modules/event-engine/events/proposal-lock/proposal-lock.service.ts

@@ -6,7 +6,10 @@ import { getProposalLockedEmailForOwner, getProposalUnlockedEmailForOwner } from
 
 @Injectable()
 export class ProposalLockService {
-  constructor(private keycloakUtilService: KeycloakUtilService, private emailService: EmailService) {}
+  constructor(
+    private keycloakUtilService: KeycloakUtilService,
+    private emailService: EmailService,
+  ) {}
 
   private async handleProposalLock(proposal: Proposal, proposalUrl: string) {
     const ownerTask = async () => {

src/modules/event-engine/events/publications/publications.service.ts

@@ -12,7 +12,10 @@ import { Publication } from 'src/modules/proposal/schema/sub-schema/publication.
 
 @Injectable()
 export class PublicationsService {
-  constructor(private keycloakUtilService: KeycloakUtilService, private emailService: EmailService) {}
+  constructor(
+    private keycloakUtilService: KeycloakUtilService,
+    private emailService: EmailService,
+  ) {}
 
   async handlePublicationCreate(proposal: Proposal, publication: PublicationCreateDto, proposalUrl: string) {
     const emailTasks: Promise<void>[] = [];

src/modules/event-engine/events/reports/reports.service.ts

@@ -11,7 +11,10 @@ import {
 
 @Injectable()
 export class ReportsService {
-  constructor(private keycloakUtilService: KeycloakUtilService, private emailService: EmailService) {}
+  constructor(
+    private keycloakUtilService: KeycloakUtilService,
+    private emailService: EmailService,
+  ) {}
 
   async handleReportCreate(proposal: Proposal, report: ReportDto, proposalUrl: string) {
     const emailTasks: Promise<void>[] = [];

src/modules/event-engine/events/status-change/status-change.service.ts

@@ -19,7 +19,10 @@ import {
 
 @Injectable()
 export class StatusChangeService {
-  constructor(private keycloakUtilService: KeycloakUtilService, private emailService: EmailService) {}
+  constructor(
+    private keycloakUtilService: KeycloakUtilService,
+    private emailService: EmailService,
+  ) {}
 
   private async handleProposalSubmit(proposal: Proposal, proposalUrl: string) {
     const ownerTask = async () => {

src/modules/event-engine/events/status-reminder/status-reminder.service.ts

@@ -18,7 +18,10 @@ import {
 
 @Injectable()
 export class StatusReminderService {
-  constructor(private keycloakUtilService: KeycloakUtilService, private emailService: EmailService) {}
+  constructor(
+    private keycloakUtilService: KeycloakUtilService,
+    private emailService: EmailService,
+  ) {}
 
   private async handleFdpgCheckReminder(proposal: ProposalWithoutContent, proposalUrl: string) {
     const fdpgTask = async () => {

src/modules/proposal/decorators/expose-history.decorator.ts

@@ -5,7 +5,7 @@ import { HistoryEventGetDto } from '../dto/proposal/history-event.dto';
 import { HistoryEvent } from '../schema/sub-schema/history-event.schema';
 import { HistoryEventType } from '../enums/history-event.enum';
 
-export const ExposeHistory = () => (target: Object, propertyKey: string) => {
+export const ExposeHistory = () => (target: object, propertyKey: string) => {
   Expose()(target, propertyKey);
   Transform((params) => {
     const user = parseGroupToUser(params.options.groups);

src/modules/proposal/decorators/expose-location-status.decorator.ts

@@ -3,7 +3,7 @@ import { parseGroupToUser } from 'src/shared/utils/user-group.utils';
 
 import { getMostAdvancedState } from '../utils/validate-access.util';
 
-export const ExposeLocationStatus = (options?: ExposeOptions) => (target: Object, propertyKey: string) => {
+export const ExposeLocationStatus = (options?: ExposeOptions) => (target: object, propertyKey: string) => {
   Expose(options)(target, propertyKey);
   Transform((params) => {
     try {

src/modules/proposal/decorators/expose-uploads.decorator.ts

@@ -14,7 +14,7 @@ const generalAccessTypes = [
   UseCaseUpload.ProposalPDF,
   UseCaseUpload.ReportUpload,
 ] as UploadType[];
-export const ExposeUpload = () => (target: Object, propertyKey: string) => {
+export const ExposeUpload = () => (target: object, propertyKey: string) => {
   Expose()(target, propertyKey);
   Transform((params) => {
     const user = parseGroupToUser(params.options.groups);

src/modules/proposal/dto/proposal/conditional-approval.dto.ts

@@ -16,7 +16,7 @@ export class ConditionalApprovalGetDto {
   @Expose()
   dataAmount: number;
 
-  @Expose({ groups: [Role.FdpgMember]})
+  @Expose({ groups: [Role.FdpgMember] })
   uploadId: string;
 
   @ExposeId()

src/modules/proposal/dto/proposal/user-project/ethic-vote.dto.ts

@@ -13,7 +13,7 @@ export class EthicVoteDto extends WithIdForObjectDto {
   @Expose()
   @IsOptional({ groups: [ProposalValidation.IsDraft] })
   @ValidateIf((ethicVote: EthicVoteDto) => ethicVote.isExisting)
-  @Equals( true)
+  @Equals(true)
   admitReputationOfAttachment: boolean;
 
   @Expose()

src/modules/proposal/dto/proposal/user-project/publication.dto.ts

@@ -3,7 +3,7 @@ import { IsEnum, IsOptional, MaxLength } from 'class-validator';
 import { ProposalValidation } from 'src/modules/proposal/enums/porposal-validation.enum';
 import { WithIdForArrayDto } from 'src/shared/dto/with-id-for-array.dto';
 import { IsNotEmptyString } from 'src/shared/validators/is-not-empty-string.validator';
-import { PublicationType } from '../../../enums/publication-type.enum'
+import { PublicationType } from '../../../enums/publication-type.enum';
 
 export class PublicationDto extends WithIdForArrayDto {
   @Expose()
@@ -22,5 +22,4 @@ export class PublicationDto extends WithIdForArrayDto {
   @IsOptional({ groups: [ProposalValidation.IsDraft] })
   @MaxLength(10000)
   authors: string;
-
 }

src/modules/proposal/schema/sub-schema/user-project/planned-publication.schema.ts

@@ -19,9 +19,9 @@ export class PlannedPublication {
 
   @Prop({
     type: Boolean,
-    default: false
+    default: false,
   })
-  noPublicationPlanned: boolean
+  noPublicationPlanned: boolean;
 }
 
 export const PlannedPublicationSchema = SchemaFactory.createForClass(PlannedPublication);

src/modules/proposal/schema/sub-schema/user-project/publication.schema.ts

@@ -1,6 +1,6 @@
 import { Document } from 'mongoose';
 import { Prop, Schema, SchemaFactory } from '@nestjs/mongoose';
-import { PublicationType } from '../../../enums/publication-type.enum'
+import { PublicationType } from '../../../enums/publication-type.enum';
 export type PublicationDocument = Publication & Document;
 
 @Schema({ _id: true })

src/modules/proposal/services/proposal-publication.service.ts

@@ -9,7 +9,10 @@ import { Publication, PublicationDocument } from '../schema/sub-schema/publicati
 
 @Injectable()
 export class ProposalPublicationService {
-  constructor(private proposalCrudService: ProposalCrudService, private eventEngineService: EventEngineService) {}
+  constructor(
+    private proposalCrudService: ProposalCrudService,
+    private eventEngineService: EventEngineService,
+  ) {}
 
   async createPublication(
     proposalId: string,

src/modules/proposal/services/proposal-upload.service.ts

@@ -11,7 +11,10 @@ import { validateUploadDeletion } from '../utils/validate-upload-deletion.util';
 
 @Injectable()
 export class ProposalUploadService {
-  constructor(private proposalCrudService: ProposalCrudService, private storageService: StorageService) {}
+  constructor(
+    private proposalCrudService: ProposalCrudService,
+    private storageService: StorageService,
+  ) {}
 
   async upload(
     proposalId: string,

src/modules/proposal/validators/is-unique-abbreviation.validator.ts

@@ -31,7 +31,7 @@ export class IsUniqueAbbreviationConstraint implements ValidatorConstraintInterf
 }
 
 export function IsUniqueAbbreviation(validationOptions?: ValidationOptions) {
-  return (object: Object, propertyName: string) => {
+  return (object: object, propertyName: string) => {
     registerDecorator({
       async: true,
       name: 'isUniqueAbbreviation',

src/modules/storage/__tests__/storage.service.spec.ts

@@ -17,7 +17,7 @@ describe('StorageService', () => {
     statObject: jest.fn(),
     removeObject: jest.fn(),
     removeObjects: jest.fn(),
-    presignedGetObject: jest.fn()
+    presignedGetObject: jest.fn(),
   };
 
   const configService = {

src/modules/storage/storage.service.ts

@@ -13,20 +13,20 @@ export class StorageService {
 
   constructor(private readonly configService: ConfigService) {
     const endPoint = this.configService.get('S3_ENDPOINT');
-    const port = parseInt(this.configService.get('S3_PORT') || "443");
+    const port = parseInt(this.configService.get('S3_PORT') || '443');
     const useSSL = (this.configService.get('S3_USE_SSL') || '').toLowerCase() === 'true';
-    const accessKey = this.configService.get("S3_ACCESSKEY")
-    const secretKey = this.configService.get("S3_SECRETKEY")
+    const accessKey = this.configService.get('S3_ACCESSKEY');
+    const secretKey = this.configService.get('S3_SECRETKEY');
 
     this.minioClient = new Client({
       endPoint,
       port,
       useSSL,
       accessKey,
-      secretKey
+      secretKey,
     });
 
-    this.bucketName = this.configService.get("S3_BUCKET");
+    this.bucketName = this.configService.get('S3_BUCKET');
   }
 
   async uploadFile(blobName: string, file: Express.Multer.File, user: IRequestUser): Promise<void> {
@@ -39,8 +39,8 @@ export class StorageService {
     const metadata: ItemBucketMetadata = {
       'Content-Type': file.mimetype,
       'Content-Disposition': `attachment; filename="${filenameRemovedNonAscii}"; filename*=UTF-8''${encodedFileName}`,
-      'userLocation': userLocationRemovedNonAscii,
-      'userId': user.userId
+      userLocation: userLocationRemovedNonAscii,
+      userId: user.userId,
     };
 
     try {
@@ -63,7 +63,7 @@ export class StorageService {
     return await this.minioClient.presignedGetObject(this.bucketName, blobName, lifetimeInSeconds);
   }
 
-  private async blobExists(blobName: string): Promise<Boolean> {
+  private async blobExists(blobName: string): Promise<boolean> {
     try {
       await this.minioClient.statObject(this.bucketName, blobName);
       return true;

src/shared/decorators/transform/expose-id.decorator.ts

@@ -1,7 +1,7 @@
 import { Expose, ExposeOptions, Transform } from 'class-transformer';
 
 // https://github.com/typestack/class-transformer/issues/494
-export const ExposeId = (options?: ExposeOptions) => (target: Object, propertyKey: string) => {
+export const ExposeId = (options?: ExposeOptions) => (target: object, propertyKey: string) => {
   Expose(options)(target, propertyKey);
   Transform(({ obj }) => {
     return obj[propertyKey];

src/shared/types/nested-key-of.type.ts

@@ -9,9 +9,9 @@ type Join<K, P> = K extends string | number
 type NestedPath<T, D extends number = 10> = [D] extends [never]
   ? never
   : T extends object
-  ? {
-      [K in keyof T]-?: K extends string | number ? `${K}` | Join<K, NestedPath<T[K], Prev[D]>> : never;
-    }[keyof T]
-  : '';
+    ? {
+        [K in keyof T]-?: K extends string | number ? `${K}` | Join<K, NestedPath<T[K], Prev[D]>> : never;
+      }[keyof T]
+    : '';
 
 type Prev = [never, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, ...0[]];

src/shared/utils/find-by-key-nested.util.ts

@@ -12,7 +12,7 @@ interface IResult {
  * @returns Returns the found object and path where the key matches the value.
  */
 export const findByKeyNested = (
-  target: Array<any> | Object,
+  target: Array<any> | object,
   key: string,
   value: string | number | boolean,
   pathAcc: (string | number)[] = [],

src/shared/validators/is-after-today.validator.ts

@@ -7,7 +7,7 @@ export const isAfterToday = (value: string): boolean => {
   return startOfToday <= incomingDate;
 };
 export function IsAfterToday(validationOptions?: ValidationOptions) {
-  return (object: Object, propertyName: string) => {
+  return (object: object, propertyName: string) => {
     registerDecorator({
       name: 'isAfterToday',
       target: object.constructor,