-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address feedback and fix noticed issued on move contact #223
Conversation
0173a6a
to
8d59d9f
Compare
Hi @kennsippell, I have been able to work on some of the feedback we received from Thanks |
8d59d9f
to
f3457b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Does this fix Token Expiration? Does this fix Timeout Handling? |
a4be02c
to
b443d4c
Compare
3a6bf0c
to
d55eade
Compare
This is the only challenge remaining so far, I am thinking on two way to fix this:
Would like to have you though on that. |
Recommend to increase the session token expiration (currently at 48h). This is straightforward. The tokens given during CHT login never expire. Can do in different PR if you desire it. |
Sure, I handled that in this PR |
Description:
We are encountering several issues with the MoveContactWorker that are causing job failures. These issues are related to token expiration, command timeouts, lack of error feedback, and server availability errors.
This PR focus on addressing them
Undefined Errors in cht Execution Investigate this failed move-contacts job #221::
Occasionally, the cht process exits with a code 1 and displays ERROR undefined, making it difficult to diagnose the root cause of the failure. The logs provide limited information about why the command failed.
Server Availability (HTTP 500):
The job occasionally encounters an HTTP 500 error while trying to connect to instances (e.g., https://kakamega-echis.health.go.ke/medic/). This could be due to server downtime or temporary server issues.
Close Issue Include cht-conf output in Job Logs #222 - Include cht-conf Output in Job Logs:
To enhance transparency and facilitate easier troubleshooting, we should ensure that the output from cht-conf commands is included directly in the job logs. This will allow us to view critical information, such as errors from cht-conf, in one place for better visibility and faster diagnosis.
Close Issue Move Contact: Improve Error Handling and Retry Logic for Interrupted/Failed #184 - Improve Error Handling and Retry Logic for Interrupted/Failed Move Contact Jobs:
Enhance the error handling and retry logic for the move contact feature to ensure robustness in cases of connectivity loss or other interruptions. This would allow for automatic retries of failed jobs due to server connectivity issues or other interruptions, reducing manual intervention.