Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#45): remove compose version string, add socket variable #46

Merged
merged 2 commits into from
Sep 30, 2024
Merged

chore(#45): remove compose version string, add socket variable #46

merged 2 commits into from
Sep 30, 2024

Conversation

mrjones-plip
Copy link
Contributor

Description

remove version from compose file, add socket variable per #45

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@mrjones-plip
Copy link
Contributor Author

similar work to medic/cht-core#9477

@mrjones-plip mrjones-plip mentioned this pull request Sep 27, 2024
Closed
dianabarsan
dianabarsan approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely 2nd!

@mrjones-plip mrjones-plip merged commit 5313c77 into main Sep 30, 2024
6 checks passed
@mrjones-plip mrjones-plip deleted the docker-socket-compose-version-45 branch September 30, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianabarsan dianabarsan dianabarsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrjones-plip @dianabarsan