Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a 30s delay brfore deploying to avoid race condition #104

Merged
merged 1 commit into from
Jun 9, 2023
Merged

feat: add a 30s delay brfore deploying to avoid race condition #104

merged 1 commit into from
Jun 9, 2023

Conversation

njogz
Copy link
Contributor

@njogz njogz commented Jun 9, 2023

Description

Add a delay when doing the deployment to kubernetes to avoid a possible race condition where the image is not ready on docker hub.

#71

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

henokgetachew
henokgetachew approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@henokgetachew henokgetachew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@njogz njogz merged commit e17f022 into main Jun 9, 2023
@njogz njogz deleted the add-delay-to-deploy-step branch June 9, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henokgetachew henokgetachew henokgetachew approved these changes

@lorerod lorerod Awaiting requested review from lorerod

@samuelimoisili samuelimoisili Awaiting requested review from samuelimoisili

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njogz @henokgetachew