Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cht-couch2pg #96

Merged
merged 6 commits into from
Jun 4, 2021
Merged

Switch to cht-couch2pg #96

merged 6 commits into from
Jun 4, 2021

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan marked this pull request as ready for review May 26, 2021 11:46
@dianabarsan
Copy link
Member Author

hey @mrsarm
I think I got everything ... I left the bin entry unchanged because the commit that added it intended additional entries to be added per database, and our default database is still called "medic".
Please review. Thanks!

@dianabarsan dianabarsan requested a review from mrsarm May 26, 2021 11:55
README.md Outdated Show resolved Hide resolved
"version": "3.3.0",
"description": "replicate medic data to postgres database",
"name": "cht-couch2pg",
"version": "3.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to do an immediate release? I would like to address first #82 , I'm trying to prioritize it but maybe it's better in the meantime to move the version change in a new PR once we decide to release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can release immediately.
Since it will be a different npm package, we're not worried someone might upgrade accidentally.

@dianabarsan dianabarsan requested a review from mrsarm June 3, 2021 16:06
Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Two minor suggestions inline.

inquirer.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
dianabarsan and others added 2 commits June 4, 2021 07:12
Co-authored-by: Gareth Bowen <[email protected]>
Co-authored-by: Gareth Bowen <[email protected]>
@dianabarsan dianabarsan merged commit 3e38727 into master Jun 4, 2021
@dianabarsan dianabarsan deleted the cht-couch2pg branch June 4, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants