Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated useview_telemetry #88

Closed
wants to merge 2 commits into from
Closed

updated useview_telemetry #88

wants to merge 2 commits into from

Conversation

kitsao
Copy link

@kitsao kitsao commented May 17, 2021

Resolves #86

@derickl derickl requested a review from mrsarm May 17, 2021 20:18
@mrsarm
Copy link
Contributor

mrsarm commented May 17, 2021

Hey @derickl , I going to create another PR to supersede this one, I discussed the approach with @kitsao . In the new PR will address also #87 . Moreover, the patch need to be applied in a new migration file, not in existent ones that are inmutable (check #78 (comment)).

I already have the fix but I found one more error that I going to address also in the same PR (I'll create a new issue with the description before the PR).

@mrsarm
Copy link
Contributor

mrsarm commented May 18, 2021

Superseded by #91.

@mrsarm mrsarm closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants