Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark view refreshes #104 #105

Closed
wants to merge 3 commits into from

Conversation

aodhan-domhnaill
Copy link

@aodhan-domhnaill aodhan-domhnaill commented Aug 6, 2021

#104

To add statistics to logs so we can see how long queries take.

@aodhan-domhnaill aodhan-domhnaill marked this pull request as draft August 6, 2021 12:35
@mrsarm
Copy link
Contributor

mrsarm commented Aug 6, 2021

@aidan-plenert-macdonald because the way migrations work , all the scripts under the migrations/ folders are immutable. When we start a new deployment, each migration script is executed one after another, and if it is an upgrade, cht-couch2pg takes care of only run the missed migrations, so any new change need to be implemented in a new script file.

This may look like inefficient because you have to delete the object and re-define it from scratch even if only one line of the whole definition is changed, but it is actually how Postgres works, there is no way to alter just a small part of a function definition , you have to destroy it and then create it again with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants