Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for later node versions #82

Open
ngaruko opened this issue May 7, 2021 · 3 comments
Open

Add support for later node versions #82

ngaruko opened this issue May 7, 2021 · 3 comments
Labels
bug dependencies Pull requests that update a dependency file

Comments

@ngaruko
Copy link

ngaruko commented May 7, 2021

At the moment, apparently medic-couch2pg does not work with node versions greater that 10.
With the v14.16.0 , I couldn't get the node . command to do anything. No error in the logs just the first json.
image

@ngaruko ngaruko changed the title Add support for later node versionz Add support for later node versions May 7, 2021
@mrsarm
Copy link
Contributor

mrsarm commented May 7, 2021

More on this was added in the README notes:

Error installing deps ERR! ... node-pre-gyp install --fallback-to-build

When installing Node.js dependencies locally or building the docker image, you might get an error like:

...
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `node-pre-gyp install --fallback-to-build`

It is probably related to a gcc library that is failing with some versions of Node and npm, try with Node 10 without updating the npm version that comes with it.

@mrsarm mrsarm added bug dependencies Pull requests that update a dependency file labels May 7, 2021
@mrsarm
Copy link
Contributor

mrsarm commented May 26, 2021

2 more things that are very related to this:

  1. Dependencies are very outdated, with 45 vulnerabilities, 2 of them critical:

    $ npm ci
    
    added 953 packages, and audited 954 packages in 25s
    
    -45 vulnerabilities (26 low, 2 moderate, 15 high, 2 critical)

    The library node-libcurl that cause the error in some versions of node / platforms is one the outdated libraries so upgrading it for sure will solve the problem.

  2. We released a new version of couch2pg around a month ago: v.0.6.0, this project relies on it but we are using instead the v0.5.0.

@garethbowen can we prioritize this so next release not only is a rebranding from mediccht-couch2pg but we also fix this that my guess is that will only require to execute npm audit and upgrade the version of couch2pg?

@garethbowen
Copy link
Member

I think couch2pg 0.5 and 0.6 are identical due to a glitch during publishing, so I don't think bumping that version will do anything. In general we should aim to bump dependencies every release at least for non-breaking changes, so it'd be good to do this, potentially for both libraries at the same time.

@mrsarm mrsarm removed their assignment Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants