Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9467): quick fixes to RapidPro #9559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Oct 18, 2024

Description

#9467

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll make sure this gets a branch release so itech can try it out, and make sure it gets in to the 4.14.0 release.

@garethbowen
Copy link
Member

We could also handle 403, and 404, more gracefully because both probably require manual intervention to fix so there's no point spamming RapidPro. Even 429s could be handled more gracefully.

But let's raise a new issue to handle these other cases because they're more temporary than the 400 being dealt with here because 400 is permanent failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants