feat(#9413): update dynamic url widget to use MutationObserver #9414
Conversation
garethbowen
requested review from
jkuester
and removed request for
garethbowen
|
@jkuester As I'm about to head on leave can I hand this over to you for review? I've approved so I don't block the eventual merge... |
…dynamic url widget mutation test
ChinHairSaintClair
force-pushed
the
add-deply-to-dynamic-url-test
branch
from
0d8fe2e
to
46488f8
Compare
|
@ChinHairSaintClair did you mean to push that last commit with the contact summary changes to this branch? |
|
@jkuester no. Accidentally pushed the other branch's work to this one 🤦 . |
ChinHairSaintClair
force-pushed
the
add-deply-to-dynamic-url-test
branch
from
91a5777
to
46488f8
Compare
| setTimeout(() => { | ||
| expect($(DynamicUrlWidget.selector).attr('href')).to.equal(`http://google.com?q=${dynamic}`); | ||
| done(); | ||
| }, 0); |
There was a problem hiding this comment.
So just for the record (for anyone that is looking into this in the future) the normal Angular way of testing async UI updates via fakeAsync does not seem to work here. And from reading online this seems to be expected (I guess the MutationObserver falls outside of what Angular has control of). In general the consensus seems to be against trying too hard to unit test MutationObserver behavior. However, since this works (at least for now) I say we ship it as is! 👍
jkuester
changed the title
Description
This approach ensures that the assertion occurs as the last action on the macro-task queue, which seems to address our pipeline issue without introducing too much additional code.
Closes #9413
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.