-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9293): refactor freetext search views #9308
Conversation
91c69a7
to
6fd1930
Compare
@jkuester could you give this a brief look when you have time? I made some changes in the view to simplify the code (like iterating over the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this last week!
ddocs/medic-db/medic-client/views/contacts_by_type_freetext/map.js
Outdated
Show resolved
Hide resolved
}); | ||
|
||
if (doc.contact && doc.contact._id) { | ||
emitMaybe('contact:' + doc.contact._id.toLowerCase(), doc.reported_date); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting case I had not noticed before.... 🤔 Looks like this is to support the ancient ANC workflow Gareth mentioned here. I cannot see any place this is currently used in the code (but after my adventures with the case_id
, who knows...).
I guess maybe it is safer to leave it... 🤷
8998dee
to
a639ace
Compare
…ata size on disk: 17.9 GB => 11.1 GB
06976a0
to
1d6abd2
Compare
I rebased the branch off |
Description
#9293
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.