-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#6289): Bumps CouchDb version to 3.3.2 #8107
Conversation
I had all the changes ready then mistakenly force checked out another branch (for a code review), and, naturally, failed to restore correctly from history repeatedly.
# Conflicts: # tests/conf.js # tests/e2e/default/client-side-transitions/create-user-for-contacts.wdio-spec.js
# Conflicts: # api/src/services/config-watcher.js
# Conflicts: # tests/integration/api/server.spec.js # tests/utils.js
# Conflicts: # couchdb/docker-entrypoint.sh
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
# Conflicts: # api/src/db.js # api/src/migrations/add-national_admin-role.js # api/src/services/config-watcher.js # api/tests/mocha/services/config-watcher.spec.js # couchdb/10-docker-default.ini # package.json # tests/integration/cht-conf/cht-conf-actions.spec.js
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
# Conflicts: # admin/src/js/services/session.js # shared-libs/cht-script-api/src/auth.js # webapp/src/ts/services/session.service.ts
Signed-off-by: Diana Barsan <[email protected]>
@garethbowen are we ready for this? |
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits inline...
Signed-off-by: Diana Barsan <[email protected]>
@dianabarsan I can't think of any reason to hold off and nothing else to test. Let's push the button and get 4.4 out. The main concern is going to be upgrading multi-node instances, right? We don't have a good solution for that right now, but we're not likely to have one next week either so I feel like it's better to get this done now before more installations are running multi-node solutions. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I think my main concern is not hitting the right config for us - which is the biggest unknown here. I'm merging. |
Description
User roles are added to db security on settings change.
Config remains unchanged with a couple of exceptions:
request_timeout
no longerinfinity
because of this error[attachments]
section back, as cht-conf depends on those settings to exist and it isn't part of default config anymore#6289
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.