Skip to content

Commit

Permalink
fix bad function reference
Browse files Browse the repository at this point in the history
  • Loading branch information
dianabarsan committed Jul 19, 2023
1 parent bf8ab8e commit f78fb3e
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 13 deletions.
3 changes: 2 additions & 1 deletion api/src/db.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ if (UNIT_TEST_ENV) {
'activeTasks',
'saveDocs',
'createVault',
'addRoleToSecurity',
'addRoleAsAdmin',
'addRoleAsMember',
];

const notStubbed = (first, second) => {
Expand Down
4 changes: 2 additions & 2 deletions api/src/migrations/add-national_admin-role.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = {
created: new Date(2017, 3, 30),
run: () => {
return Promise.resolve()
.then(() => db.addRoleToSecurity('_users', 'national_admin'))
.then(() => db.addRoleToSecurity(environment.db, 'national_admin'));
.then(() => db.addRoleAsMember('_users', 'national_admin'))
.then(() => db.addRoleAsMember(environment.db, 'national_admin'));
}
};
2 changes: 1 addition & 1 deletion api/src/services/config-watcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ const addUserRolesToDb = async () => {
}

for (const role of Object.keys(roles)) {
await db.addRoleToSecurity(environment.db, role, false);
await db.addRoleAsMember(environment.db, role);
}
};

Expand Down
16 changes: 8 additions & 8 deletions api/tests/mocha/services/config-watcher.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ describe('Configuration', () => {
it('reloads settings settings doc is updated', () => {
settingsService.update.resolves();
settingsService.get.resolves({ settings: 'yes' });
sinon.stub(db, 'addRoleToSecurity');
sinon.stub(db, 'addRoleAsMember');
sinon.stub(config, 'get').withArgs('roles').returns({ chw: {} });
sinon.stub(environment, 'db').get(() => 'medicdb');

Expand All @@ -238,14 +238,14 @@ describe('Configuration', () => {
chai.expect(config.set.callCount).to.equal(1);
chai.expect(config.set.args[0]).to.deep.equal([{ settings: 'yes' }]);
chai.expect(config.get.withArgs('roles').callCount).to.equal(1);
chai.expect(db.addRoleToSecurity.args).to.deep.equal([['medicdb', 'chw', false]]);
chai.expect(db.addRoleAsMember.args).to.deep.equal([['medicdb', 'chw']]);
});
});

it('should add all configured user roles to the main database', () => {
settingsService.update.resolves();
settingsService.get.resolves({ settings: 'yes' });
sinon.stub(db, 'addRoleToSecurity');
sinon.stub(db, 'addRoleAsMember');
sinon.stub(config, 'get')
.withArgs('roles')
.returns({
Expand All @@ -262,11 +262,11 @@ describe('Configuration', () => {
chai.expect(config.set.callCount).to.equal(1);
chai.expect(config.set.args[0]).to.deep.equal([{ settings: 'yes' }]);
chai.expect(config.get.withArgs('roles').callCount).to.equal(1);
chai.expect(db.addRoleToSecurity.args).to.deep.equal([
['medicdb', 'chw1', false],
['medicdb', 'chw2', false],
['medicdb', 'chw3', false],
['medicdb', 'chw4', false],
chai.expect(db.addRoleAsMember.args).to.deep.equal([
['medicdb', 'chw1'],
['medicdb', 'chw2'],
['medicdb', 'chw3'],
['medicdb', 'chw4'],
]);
});
});
Expand Down
2 changes: 1 addition & 1 deletion couchdb/10-docker-default.ini
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
; couchdb/local.d/package.ini

[fabric]
request_timeout = 3600 ; 1 hour in seconds
request_timeout = 31536000 ; 1 year in seconds

[query_server_config]
os_process_limit = 1000
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"standard-wdio-local": "export VERSION=$(node ./scripts/build/get-version.js) && grunt e2e-env-setup && wdio run ./tests/e2e/standard/wdio.conf.js",
"default-wdio-mobile-local": "export VERSION=$(node ./scripts/build/get-version.js) && grunt e2e-env-setup && wdio run ./tests/e2e/default-mobile/wdio.conf.js",
"e2e-integration": "mocha --config tests/integration/.mocharc.js ",
"e2e-integration-local": "export VERSION=$(node ./scripts/build/get-version.js) && grunt e2e-env-setup && mocha --config tests/integration/.mocharc.js ",
"wdio": "wdio run ./tests/e2e/default/wdio.conf.js",
"upgrade-wdio": "wdio run ./tests/e2e/upgrade/wdio.conf.js",
"standard-wdio": "wdio run ./tests/e2e/standard/wdio.conf.js",
Expand Down

0 comments on commit f78fb3e

Please sign in to comment.