-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: do not run Couch container for unit tests #639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently GitHub is not smart enough to realize that this is a modified version of the test/integration/session-token.spec.js file. I am afraid you will have to manually diff this to see what actually changed in the file....
(TLDR is that I was able to remove a lot of code.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks for cleaning up those tests
Description
Currently, the cht-conf unit tests spin up a Couch docker container before the tests run and then tear it down at the end. It turns out that Couch instance was only being used in 2 test files:
limit
andskip
view query options are ignored whenkeys
are used, if the adapter is not http pouchdb/pouchdb#8370. However, that issue was fixed and our current Pouch version includes the fix! So, I have updated these tests to just use a local Pouch instance.Code review items
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.