Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#635): update upload-artifact GH action to version 4 #636

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix(#635): update upload-artifact GH action to version 4 #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a36aea
fix(#635): update upload-artifact GH action to version 4
sugat009 Oct 8, 2024
f7f997a
fix e2e tests
m5r Oct 9, 2024
d213205
Merge branch '637-fix-e2e-tests' into 635-update-upload-artifact-to-v…
m5r Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: npm ci and test
run: npm ci && npm test
- name: Archive Results
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: Coverage Report ${{ matrix.node-version }}
path: |
Expand Down
4 changes: 3 additions & 1 deletion test/e2e/edit-app-settings.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const {

describe('edit-app-settings', () => {
const projectName = DEFAULT_PROJECT_NAME;
const findLanguage = (settingsLanguages, locale) => settingsLanguages.find(language => language.locale === locale);

before(async () => {
await initProject(projectName);
Expand All @@ -24,7 +25,8 @@ describe('edit-app-settings', () => {
it('disables a language, recompile, and push app settings', async () => {
const url = await getProjectUrl(projectName);
const baseSettings = await request.get({ url: `${url}/api/v1/settings`, json: true });
baseSettings.languages.forEach(language => expect(language.enabled).to.be.true);
expect(findLanguage(baseSettings.languages, 'en').enabled).to.be.true;
expect(findLanguage(baseSettings.languages, 'fr').enabled).to.be.true;
expect(baseSettings.locale).to.equal('en');
expect(baseSettings.locale_outgoing).to.equal('en');

Expand Down