fix(#602): fix errors with validate functions #604
Conversation
|
@1yuv it looks like all your builds are failing, and it seems like your change is causing it :( |
There was a problem hiding this comment.
@1yuv
I've been looking at this failing test and it's completely broken. On main, the error that makes the test pass is not the one that is expected, a form validation error, instead it's assuming the environment is initialized when it's not.
You can easily check this by throwing or logging the error.
I'm not even sure how this test came to be, it doesn't seem we even run validations on upload anymore. I think it's safe to disable this test and create an issue to check which tests should actually run for upload-forms.
test/lib/environment.spec.js
Outdated
| @@ -17,6 +17,13 @@ describe('environment', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('apiUrl initialize empty', ()=>{ | |||
| it('undefined apiUrl remains undefined', ()=>{ | |||
There was a problem hiding this comment.
Upon further checks, the value that comes when the instance is not required is Boolean false, not undefined, so I think this test should reflect this.
|
🎉 This PR is included in version 3.21.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Fixes issue with #602, which was cause by recent change in apiUrl
#602
Code review items
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.