Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#599): support node 20 #601

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix(#599): support node 20 #601

merged 1 commit into from
Jan 26, 2024

Conversation

garethbowen
Copy link
Contributor

Description

[description]

#599

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or integration tests where appropriate
  • Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@garethbowen garethbowen requested a review from jkuester January 25, 2024 08:47
@garethbowen
Copy link
Contributor Author

@jkuester I was holding off on this until the cht-core PR was ready as the e2e tests execute cht-conf so it works as an integration test to ensure cht-conf executes under Node 20, but that one's being held up by unrelated changes. That PR has run sufficiently to prove support so I'm thinking we'll merge this one now to clean it up.

Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 Too heavy on the complexity here!

@garethbowen garethbowen merged commit ddd3064 into main Jan 26, 2024
14 checks passed
@garethbowen garethbowen deleted the 599-support-node-20 branch January 26, 2024 06:25
@medic-ci
Copy link
Collaborator

🎉 This PR is included in version 3.21.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants