Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#578): accept array for start_from #579

Merged
merged 1 commit into from
Oct 21, 2023
Merged

feat(#578): accept array for start_from #579

merged 1 commit into from
Oct 21, 2023

Conversation

1yuv
Copy link
Member

@1yuv 1yuv commented Oct 14, 2023

Description

Accept dates on start_from
#578

Related to medic/cht-core#8633

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or integration tests where appropriate
  • Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@1yuv 1yuv requested a review from garethbowen October 14, 2023 02:28
Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

@1yuv 1yuv merged commit 5da51f8 into main Oct 21, 2023
12 checks passed
@1yuv 1yuv deleted the 578_schedule branch October 21, 2023 23:29
@garethbowen
Copy link
Member

@1yuv Unfortunately this was merged without a valid commit format so it won't get released. Can you push another change following the commit format so this gets released?

@1yuv
Copy link
Member Author

1yuv commented Oct 25, 2023

Oops, I missed that again. Thanks @garethbowen , I've created a PR here by adding one more test.

@medic-ci
Copy link
Collaborator

🎉 This PR is included in version 3.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants