Cholera Use Case V4 #29
Conversation
AsinineFatuity
added
bug
|
Hi @esthermmoturi can you add me as a reviewer? |
|
Hi @paulpascal I can't find you on the dropdown for suggested reviewers. I hope you being assigned by Mariachana helps still with that |
|
@paulpascal may you review this. I am closing the other outdated PRs |
|
Thanks @AsinineFatuity |
There was a problem hiding this comment.
Impressive and clean work @AsinineFatuity !
Just left some feedback.
| <label ref="jr:itext('/data/inputs/contact:label')"/> | ||
| <group appearance="field-list" ref="/data/inputs/contact/init"> | ||
| <select1 ref="/data/inputs/contact/init/conduct_registration"> | ||
| <label ref="jr:itext('/data/inputs/contact/init/conduct_registration:label')"/> |
There was a problem hiding this comment.
Was not able to find this section the design
| <input ref="/data/repeat/child/n_age"> | ||
| <label ref="jr:itext('/data/repeat/child/n_age:label')"/> | ||
| </input> | ||
| <input ref="/data/repeat/child/phone"> |
There was a problem hiding this comment.
I think phone number is relevant only for >= 18 years old according to the design
| <input ref="/death_report/patient_death_details/place_of_death_other"> | ||
| <label ref="jr:itext('/death_report/patient_death_details/place_of_death_other:label')"/> | ||
| </input> | ||
| <input appearance="multiline" ref="/death_report/patient_death_details/death_information"> |
There was a problem hiding this comment.
Was not able to see this section in the design.
Is it this a malaria related question is missing.
| <bind nodeset="/data/household_member/person_age_years" type="string" calculate="floor( difference-in-months( ../dob_iso, today() ) div 12 )"/> | ||
| <bind nodeset="/data/household_member/person_age_months" type="string" calculate="floor(difference-in-months( ../dob_iso, today() ))"/> | ||
| <bind nodeset="/data/household_member/n_age" readonly="true()" type="string" relevant="false()"/> | ||
| <bind nodeset="/data/household_member/phone" type="tel" relevant=" /data/household_member/person_age_years >=10" jr:constraintMsg="Please make sure the number is not already in use by another person and is in the format 07XX XXX XXX" constraint="1"/> |
There was a problem hiding this comment.
I think phone number is relevant only for >= 18 years old according to the design
| return allFields; | ||
| } | ||
|
|
||
| function getMostRecentReport(reports, form) { |
There was a problem hiding this comment.
This function is already available in cht-nootils.
I suggest using it ? Like Utils.getMostRecentReport. (The Utils object is globally accessible)
You can check here to see more utility functions
| @@ -0,0 +1,16 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
Nice, maybe you can make use of this in the whole project (not only for tests) ?
What about having constant containing all forms too?
| expect(referralsGiven).to.have.lengthOf(1); | ||
| expect(referralsGiven[0].value).to.nested.include({pass: 1, total: 1}); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I would have like to see a case when the target does not increment ?
Brink Innovation/Example CHT application/disease-surveillance/README.md
Outdated
Show resolved
Hide resolved
| "context": { | ||
| "place": false, | ||
| "person": true, | ||
| "expression": "!contact.date_of_death && !summary.muted && ageInYears(contact) > 0" |
There was a problem hiding this comment.
Is this by design please ? Are under 5 also concerned by this form?
BTW I am not able to see the Under 5 Assessment Form?
| const { chpTargets, chaTargets, dsoTargets } = require('./app_targets'); | ||
| module.exports = [...chpTargets, ...chaTargets, ...dsoTargets]; |
There was a problem hiding this comment.
Would have like to see some test against the other targets?
…README.md Co-authored-by: paulpascal <[email protected]>
We didn't manage to lump together
household_memberandhousehold_contacttype as it prevented creation of new households and even members. The work around was to name them same way in contact summaries for now as we investigate the issue further.