Updated workflows, forms and condition cards #23

brian-gacheru · 2023-10-27T12:26:40Z

No description provided.

derickl

Nice work @brian-gacheru
I've only looked at the javascript code and left some feedback inline

cc @esthermmoturi

POSHIT/Example CHT application/malaria-usecase-cht/nools-extras.js

derickl · 2023-10-29T15:07:23Z

POSHIT/Example CHT application/malaria-usecase-cht/nools-extras.js

+//   });
+//   return result;
+// }
+function getMostRecentReportForm(reports, form) {


This is already implemented in cht-nootils.

You can access this method using Utils.getMostRecentReport

The Utils object is globally accessible. The latest cht-core might not have the latest cht-nootils. It helps to check which version of the utility is released in a given cht-core release.

For some reason, the function in cht-nootils does not work as expected in some forms.

Do you have more information to go by? I'm keen to learn how you are using this.

When fetching the most recent reports for a household or household member, using the method in Utils crashes the form giving an error but when we use the function in nools-extras it works. Both seem to be implemented the same way but for some reason using the method in cht-nootils crashes the app.

POSHIT/Example CHT application/malaria-usecase-cht/nools-extras.js

POSHIT/Example CHT application/malaria-usecase-cht/tasks.js

derickl · 2023-10-29T16:27:36Z

POSHIT/Example CHT application/malaria-usecase-cht/tasks.js

+    events: [
+      {
+        id: FORMS.MALARIA_ASSESSMENT_FOR_PREGNANT_MOTHERS,
+        start: 30,


This is a very long lead time. Is this by design? Are the referral follow up dates way into the future to warrant this?

This is by design since we want to follow up with a pregnant woman every month.

derickl · 2023-10-29T16:34:50Z

POSHIT/Example CHT application/malaria-usecase-cht/nools-extras.js

+const { DateTime } = require('luxon');
+const { FORMS } = require('./shared-extras');
+const { getField, isFirstReportNewer } = require('cht-nootils')();
+
 const isFormArraySubmittedInWindow = (reports, formsArray, startTime, endTime) => {


This function exists in cht-nootils. I would recommend reusing it unless you have a very specific need to override some behaviour

@brian-gacheru , you have maintained this. Are you using it to override the function in cht-nootils?

Yes this function overrides the one in cht-nootils. Using the one in cht-nootils crashes the app

POSHIT/Example CHT application/malaria-usecase-cht/nools-extras.js

derickl

This has come a long way @brian-gacheru. Nice work!
I've left some feedback inline

derickl · 2024-03-21T09:31:18Z

POSHIT/Example CHT application/malaria-usecase-cht/contact-summary-extras.js

+};
+
+const isPregnant = (allReports)  => {
+  return allReports.some(report => isActivePregnancy(report));


We also have to check that:

there's no subsequent delivery

the pregnancy age does not exceed 40-42 weeks

the pregnancy has not been terminated

A potential example might look like this

derickl · 2024-03-21T09:35:36Z

POSHIT/Example CHT application/malaria-usecase-cht/contact-summary.templated.js

+const under5AssessmentReport = getMostRecentReportForm(reports, [FORMS.CHILD_ASSESSMENT]);
+const under5AssessmentFollowUpreport = getMostRecentReportForm(reports, [FORMS.CHILD_FOLLOW_UP]);
+const memberAssessmentReport = getMostRecentReportForm(reports, [FORMS.HOUSEHOLD_MEMBER_ASSESSMENT]);
+const u5MalariaConfirmed = !!under5AssessmentFollowUpreport 


it's easier to spot boolean variables if there are named in a manner that communicates that. e.g isXYZ or hasXYZ.
Consider renaming for redability

derickl · 2024-03-21T09:37:22Z

POSHIT/Example CHT application/malaria-usecase-cht/contact-summary.templated.js

+  { appliesToType: CONTACT_TYPES.AREA_SUPERVISOR_REGION, label: 'contact.phone', value: thisContact.contact && thisContact.contact.phone, width: 4 },
+  { appliesToType: CONTACT_TYPES.AREA_SUPERVISOR_REGION, label: 'contact.parent', value: thisLineage, filter: 'lineage' },
+  { appliesToType: CONTACT_TYPES.AREA_SUPERVISOR_REGION, label: 'Notes', value: thisContact.contact && thisContact.contact.notes, width: 12 },
+  { appliesToType: CONTACT_TYPES.AREA_COMMUNITY_HEALTH_SUPERVISOR, label: 'contact.phone', value: thisContact.phone, width: 4 },


Is a name needed for the 'area supervisor region'?

If there was consistency in the way place / person contacts were rendered, this code block could be significantly reduced.

const fields = []; if (person_type) { fields.push(...) fields.push(..) } else { fields.push(...) fields.push(...) }

derickl · 2024-03-21T09:48:40Z

POSHIT/Example CHT application/malaria-usecase-cht/contact-summary.templated.js

-          return DateTime.fromISO(ammendmentDate).isValid ? ammendmentDate : null;
+        value: function() { 
+          const assessmentValue = getField(householdAssessmentReport, 'malaria_prone');
+          const followUpValue = householdFollowUpReport !== undefined ? getField(householdFollowUpReport, 'malaria_prone') : undefined;


In some cases, you are using undefined while in others you are using null. Let's be consistent

derickl · 2024-03-22T15:19:45Z

POSHIT/Example CHT application/malaria-usecase-cht/contact-summary.templated.js

-        value: function(report) { 
-          return getField(report, 'malaria_prone') ? 'Yes' : 'No';
+        value: function() { 
+          const assessmentValue = getField(householdAssessmentReport, 'malaria_prone');


assessmentValue does not quite communicate your intention here. It might be more clear if it were renamed to isMalariaProne or similar. That way, you have an idea of what value it would contain.

followUpValue is also unclear.

const isMalariaProne = !!householdAssessmentReport && getField(householdAssessmentReport, 'malaria_prone') === 'true'

This way it would be a boolean value (either true or false).

The same pattern would apply for followUpValue and isContactAvailable

derickl · 2024-03-22T18:22:20Z

POSHIT/Example CHT application/malaria-usecase-cht/tasks.js

+  //   appliesIf: function (contact, report) {
+  //     return isAlive(contact) && !isPregnancyTaskMuted(contact) && Utils.getField(report, 'group_malaria_assessment_for_pregnant_mothers.treatment_referral_follow_up_date');
+  //   },
+


if this isn't going to be used, can we delete?

derickl · 2024-03-22T18:23:09Z

POSHIT/Example CHT application/malaria-usecase-cht/tasks.js

+        start: 30,
+        end: 30,
+        dueDate: function (event, contact, report) {
+          return new Date(Utils.getField(report, 'group_malaria_assessment_for_pregnant_mothers.referral_follow_up_date'));


What would be a safe default if the field doesn't return a value?

derickl · 2024-03-22T18:24:51Z

POSHIT/Example CHT application/malaria-usecase-cht/tasks.js

+    },
+
+    resolvedIf: function (contact, report, event, dueDate) {
+      if(isPregnancyTaskMuted(contact) && !isAlive(contact)) {return true;}


This reads as 'return true if the pregnancy is muted and the contact is deceased'.

I think it should be either or. Thoughts?

derickl · 2024-03-22T19:15:55Z

...application/malaria-usecase-cht/test/targets/household_members_with_malaria_symptoms.spec.js

+    householdMemberAssessmentResult = await harness.fillForm(FORMS.MEMBER_FOLLOW_UP, ...memberAssessmentTask.followUpMalaria);
+    expect(householdMemberAssessmentResult.errors).to.be.empty;
+    //check that target increments
+    householdMembersWithMalaria = await harness.getTargets({ type: TARGETS.MEMBERS_WITH_MALARIA });


I think we should check for the target change after submitting the the assessment

derickl · 2024-03-22T19:17:10Z

...application/malaria-usecase-cht/test/targets/household_members_with_malaria_symptoms.spec.js

+
+    harness.subject = result.contacts[0];
+    //assess new member
+    householdMemberAssessmentResult = await harness.fillForm(FORMS.MEMBER_ASSESSMENT, ...memberAssessment.showSymptoms);


This test seems repetitive. We could have used the opportunity to assert that an non-assessment or a an assessmemnt without malaria does not increment

Updated workflows, forms and condition cards

431add8

brian-gacheru requested a review from esthermmoturi October 27, 2023 12:27

derickl requested changes Oct 29, 2023

View reviewed changes

gachez added 4 commits November 24, 2023 15:08

updated forms and condition cards

38b4461

Added fix to pregnancy condition cards and household assessment form

f77c2db

Updated contact summaries to follow specifications given

b5cb5ed

remove unused functions and rename for clarity

827bd9a

nsitaula requested a review from derickl March 14, 2024 08:11

derickl requested changes Mar 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated workflows, forms and condition cards #23

Updated workflows, forms and condition cards #23

brian-gacheru commented Oct 27, 2023

derickl left a comment

derickl Oct 29, 2023

brian-gacheru Feb 5, 2024

derickl Feb 7, 2024

brian-gacheru Feb 20, 2024

derickl Oct 29, 2023

brian-gacheru Feb 5, 2024

derickl Oct 29, 2023

esthermmoturi Feb 7, 2024

brian-gacheru Feb 20, 2024

derickl left a comment

derickl Mar 21, 2024

derickl Mar 21, 2024

derickl Mar 21, 2024

derickl Mar 21, 2024

derickl Mar 21, 2024

derickl Mar 22, 2024

derickl Mar 22, 2024

derickl Mar 22, 2024

derickl Mar 22, 2024

derickl Mar 22, 2024

derickl Mar 22, 2024

Updated workflows, forms and condition cards #23

Are you sure you want to change the base?

Updated workflows, forms and condition cards #23

Conversation

brian-gacheru commented Oct 27, 2023

derickl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derickl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment