Add FTS for app name and windows name and fix CI pipeline #967
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
|
hmm no |
|
did you read the code? |
|
we already have fts on these columns you need to change |
|
It seems in db.rs the FTS has been added for app name and windows name and also there are tests too. I think have to run them and check their functionality. But pipeline is failing to check with that tests |
|
i usually do here's the thing to change (and other similar queries) screenpipe/screenpipe-server/src/db.rs Line 733 in 6d03f29 LIKE is very inefficient, O(n) while FTS is O(logn) for search so it would likely make search with window/app name more than 1000x faster also if you make this one work better: not super important but i'd add tip for it |
|
@louis030195 I am too fixing the build :) Idk why CI is flaky with all compilation errors |
|
@louis030195 Finally it got compiled! Can you merge this PR? I will push new pr for FTS. |
Yashashwini2003
changed the title
Yashashwini2003
changed the title
Yashashwini2003
force-pushed
the
add-fts
branch
from
96d08ec to
cc0b1c6
Compare
Yashashwini2003
force-pushed
the
add-fts
branch
from
cc0b1c6 to
7501312
Compare
| @@ -13,6 +13,9 @@ use xcap_macoswin::{Monitor, Window, XCapError}; | |||
| #[cfg(target_os = "linux")] | |||
| use xcap::{Monitor, Window, XCapError}; | |||
|
|
|||
| #[cfg(target_os = "windows")] | |||
| use xcap_win::{Monitor, Window, XCapError}; | |||
There was a problem hiding this comment.
can you remove this change
|
does not compile |
|
any update |
|
Fill fix them |
|
@louis030195 Can I fix all this on weekend? |
sure |
name: pull request
about: submit changes to the project
title: "[pr] "
labels: ''
assignees: ''
description
brief description of the changes in this pr.
related issue: #
how to test
add a few steps to test the pr in the most time efficient way.
if relevant add screenshots or screen captures to prove that this PR works to save us time.
if you think it can take more than 30 mins for us to review, we will pay between $20 and $200 for someone to review it for us, just ask in the pr.
/claim #964
Fixes #964