Fix auto-destruct behavior on Windows when window is closed

[Yashashwini2003]

Windows: The application now terminates the process by std::process::exit(0) when the window is closed similar to that the app behaves to macOS where the process exits when the window is closed.

Closes #926
/claim #926

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
screenpipe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 2:50pm

[request-info]

hey! thanks for the contribution. would you mind adding more details about: - what problem you're trying to solve - why this change is needed - any relevant context or screenshots
this helps us review and merge faster! 🚀

[algora-pbc]

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

[louis030195]

this is wrong

the cli should kill itself, not the app, the app cannot kill the cli if it's not alive

[Yashashwini2003]

Got it! Just followed with the closed issue of same and got context of it

[varshith257]

@Yashashwini2003 I think we need auto_destructor in the sidecar.rs . Something like this, sidecar process monitors the app's lifecycle and terminate(auto destruct) itself when the app is no longer running.

[Yashashwini2003]

I have observed --auto-destruct-pid in sidecar.rs but it seems it never used while this flag implemented. Now, I think the auto_destruct_monitor function added need to actively monitor the parent process, the sidecar exits cleanly if the parent process is no longer alive. Need to tweak some with parsing the flag from spawn_sidecar and invoke auto_destruct_monitor.

Will update on it

[Yashashwini2003]

@louis030195 let me know if my thought process is on right way. If yes, I will update with it or else any suggestions on your mind?

[louis030195]

it works on macos

screenpipe/screenpipe-server/src/bin/screenpipe-server.rs

Line 767 in 3f520b8

if let Some(pid) = cli.auto_destruct_pid {

[Yashashwini2003]

@louis030195 That makes sense. Replaced tasklist with OpenProcess on Windows for PID monitoring. tasklist was error-prone due to output parsing and unnecessary process name checks and also some needless permissions results it error prone. The new implementation directly queries the Windows API to verify if the process is alive which should perfectly align behavior with macOS's ps-based monitoring.

[louis030195]

@Yashashwini2003 nice!

any chance you can share a screen recording to confirm it works - i cannot test myself

eg show task manager, run app without dev mode, start screenpipe recording, close app, and we should see in task manager that the CLI is stopped

then can merge

[Yashashwini2003]

@louis030195 My desktop have got into service , will be return in 3 days. Meanwhile I will ask anyone to test it from context of 368. If not I will test it and post video once my desktop is back

I am using codespaces for now :(

[Yashashwini2003]

I will tag @meltiso or @varshith257 anyone can test this PR

[louis030195]

any update

[Yashashwini2003]

@meltiso Are you able to test this?

[louis030195]

i mean just send a video screen recording

[louis030195]

@Neptune650 any chance you can test this? eg

1. start app non dev mode
2. make sure backend is running
3. close app
4. backend should have been closed too

[louis030195]

@Yashashwini2003 can you do this:

• stop the app using the new method
• fallback to old method

(for windows)

and then ill merge