Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controls): add tray menu and shortcut for recording #846

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

onyedikachi-david
Copy link
Contributor

description

  • Add stop/start recording buttons to tray menu
  • Implement global shortcut for recording control
  • Add unified state management for recording status
  • Improve process detection reliability
  • Add proper error handling and user feedback
  • Also fixed the issues in the previous pull request Feat/tray menu/shortcut recording #552

related issue: #713
/claim #713
Fixes: #713

Screen.Recording.2024-12-05.at.02.44.32.mov
Screen.Recording.2024-12-05.at.02.49.19.mov

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 8:12pm

@louis030195
Copy link
Collaborator

louis030195 commented Dec 6, 2024

i can still show screenpipe through shortcut when shortcut is disabled

@onyedikachi-david
Copy link
Contributor Author

Screen.Recording.2024-12-06.at.03.25.10.mp4

@louis030195 Seems to be the other way around for me.

@m13v
Copy link
Contributor

m13v commented Dec 6, 2024

is the feature to stop/start server? or specifically recording? when i press it my CLI stops

@m13v
Copy link
Contributor

m13v commented Dec 6, 2024

i can still show screenpipe through shortcut when shortcut is disabled

the same thing, it's just the text is mixed up, the toggle should be inverted

@m13v
Copy link
Contributor

m13v commented Dec 6, 2024

let's clean up warning, i see them when i build tauri app
logs.txt

@onyedikachi-david
Copy link
Contributor Author

is the feature to stop/start server? or specifically recording? when i press it my CLI stops

Exactly to restart the server/CLI if it errors out or one just wants to stop and restart.

@onyedikachi-david
Copy link
Contributor Author

onyedikachi-david commented Dec 6, 2024

Screen.Recording.2024-12-06.at.17.17.05.mov

how do you see this @louis030195 @m13v

Signed-off-by: David Anyatonwu <[email protected]>
@m13v
Copy link
Contributor

m13v commented Dec 6, 2024

i think the design is fine, is it supposed to restrart the server when u press it again?

@onyedikachi-david
Copy link
Contributor Author

i think the design is fine, is it supposed to restart the server when u press it again?

Only when the server is off, one can use the shortcut to restart it.

@m13v
Copy link
Contributor

m13v commented Dec 7, 2024 via email

@onyedikachi-david
Copy link
Contributor Author

does it restart for you? i don't thinking it reacts and the same for show overlay, if u press the short cut again should it be disabled?

On Fri, Dec 6, 2024 at 12:58 PM David Anyatonwu @.> wrote: i think the design is fine, is it supposed to restart the server when u press it again? Only when the server is off, one can use the shortcut to restart it. — Reply to this email directly, view it on GitHub <#846 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY62CDB6T2HJKN5VMKZXSND2EIFY5AVCNFSM6AAAAABTBN7RPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRUGE3DINRTGE . You are receiving this because you were mentioned.Message ID: @.>

When disabled, it doesn't react (as expected) to both shortcut trigger; but should when enabled.

@louis030195
Copy link
Collaborator

does this work now?

seems like very outdated now
kinda tired of testing and is not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bounty] make #552 work
3 participants