-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add timeline fps in api request #760
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@louis030195 |
@tribhuwan-kumar great! kinda hard to see the difference for some reason when i adjust the fps though, maybe just hard to notice, any chance you can share screenshot or video that show difference? also can you maybe add a text/label to make it more clear what is the slider without having to hover the ? PS: if you ever find how to fix the issue where timeline load forever despite reload sometimes? (optional) |
there is some conflict, fixing it |
its hard to see difference, idk why!
the changes for getting target fps through api parameter is correct and i tried with value 1000 for target fps, still can't see any difference
|
@louis030195 |
name: pull request
about: it'll let pass timeline fps through the api request and added a slider in app which will let user to set stream fps in timeline, also, i was encountering some onnx build error from
screenpipe-audio/build.rs
(only locally, in ci it was fine) so i did some changes in it. i've tested it, please test it again before merging!!title: "[pr] "
labels: ''
assignees: ''
feat: #693
description
brief description of the changes in this pr.
related issue: #693
type of change
how to test
add a few steps to test the pr in the most time efficient way.
if relevant add screenshots or screen captures to prove that this PR works to save us time.
checklist
additional notes
any other relevant information about the pr.
/claim #693