Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeline fps in api request #760

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

tribhuwan-kumar
Copy link
Contributor

@tribhuwan-kumar tribhuwan-kumar commented Nov 25, 2024


name: pull request
about: it'll let pass timeline fps through the api request and added a slider in app which will let user to set stream fps in timeline, also, i was encountering some onnx build error from screenpipe-audio/build.rs (only locally, in ci it was fine) so i did some changes in it. i've tested it, please test it again before merging!!
title: "[pr] "
labels: ''
assignees: ''

feat: #693


description

brief description of the changes in this pr.

related issue: #693

type of change

  • bug fix
  • new feature
  • breaking change
  • documentation update

how to test

add a few steps to test the pr in the most time efficient way.

if relevant add screenshots or screen captures to prove that this PR works to save us time.

checklist

  • MOST IMPORTANT: this PR will require less than 30 min to review, merge, and release to production and not crash in the hand of thousands of users
  • i have read the CONTRIBUTING.md file
  • i have updated the documentation if necessary
  • my changes generate no new warnings
  • i have added tests that prove my fix is effective or that my feature works

additional notes

any other relevant information about the pr.
/claim #693

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 0:57am

@tribhuwan-kumar
Copy link
Contributor Author

there was issue with icons.rs, it was creating new powershell command window everytime when function invoked.
fixed it in this commit 92ebf01
#706 & #643

@tribhuwan-kumar
Copy link
Contributor Author

@louis030195
i test it again & everything is fine, maybe you could review it!

@louis030195
Copy link
Collaborator

louis030195 commented Nov 27, 2024

@tribhuwan-kumar great!

kinda hard to see the difference for some reason when i adjust the fps though, maybe just hard to notice, any chance you can share screenshot or video that show difference?

also can you maybe add a text/label to make it more clear what is the slider without having to hover the ?

image

PS: if you ever find how to fix the issue where timeline load forever despite reload sometimes? (optional)

@tribhuwan-kumar
Copy link
Contributor Author

@tribhuwan-kumar great!

kinda hard to see the difference for some reason when i adjust the fps though, maybe just hard to notice, any chance you can share screenshot or video that show difference?

also can you maybe add a text/label to make it more clear what is the slider without having to hover the ?
image

PS: if you ever find how to fix the issue where timeline load forever despite reload sometimes? (optional)

there is some conflict, fixing it
i'll share a demo soon

@tribhuwan-kumar
Copy link
Contributor Author

@louis030195

its hard to see difference, idk why!
increasing value from 0.1 means increasing the numbers of image in timeline right? but i see no difference even after increasing the value

let frame_interval = (source_fps / 0.1).round() as i64; // Using 0.1 as target FPS

the changes for getting target fps through api parameter is correct and i tried with value 1000 for target fps, still can't see any difference

�[2m2024-12-03T17:07:16.868949Z�[0m �[32m INFO�[0m �[2mscreenpipe_server::server�[0m�[2m:�[0m streaming frames from 2024-12-02 18:31:00 UTC to 2024-12-03 17:05:16.396 UTC    
�[2m2024-12-03T17:07:16.883285Z�[0m �[32m INFO�[0m �[2mscreenpipe_server::server�[0m�[2m:�[0m TARGET FPS: 1000.0    
�[2m2024-12-03T17:07:27.185954Z�[0m �[32m INFO�[0m �[2mscreenpipe_server::video_cache�[0m�[2m:�[0m extracting frames with interval 0 (source: 1fps, target: 1000fps)

@tribhuwan-kumar
Copy link
Contributor Author

{807DE75B-767A-4E25-B814-4E955D70025E}
should i fix this issue?
the slider bar is going too back

@tribhuwan-kumar
Copy link
Contributor Author

PS: if you ever find how to fix the issue where timeline load forever despite reload sometimes? (optional)

@louis030195
the timeline load forever happens when there isn't enough data to stream frames. if you wait few minutes the refresh it again. it won't happen :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants