fix: use lang: powershell on windows #1040
Open
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
louis030195
reviewed
Dec 24, 2024
| @@ -138,7 +139,10 @@ export function CliCommandDialog({ settings }: CliCommandDialogProps) { | |||
| </DialogDescription> | |||
| </DialogHeader> | |||
| <div className="overflow-x-auto"> | |||
| <CodeBlock language="bash" value={generateCliCommand()} /> | |||
| <CodeBlock | |||
| language={platform() === "windows" ? "powershell" : "bash"} | |||
There was a problem hiding this comment.
nice!
can you do bun tauri build
usually you cannot use platform() like this - build crash
because nextjs does not know tauri APIs
so you need to put it in a function or useeffect
maybe it would make sense to create a hook because we have useeffect for this everywhere - kinda dirty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: pull request
about: submit changes to the project
title: "[pr] "
labels: ''
assignees: ''
description
Earlier , we were showing the commands on windows as "bash". But know it shows powershell on windows which is the expected behavior because User might think that we do not support powershell or the given command can only be executed on bash.
related issue: #1039
how to test
add a few steps to test the pr in the most time efficient way.
if relevant add screenshots or screen captures to prove that this PR works to save us time.
if you think it can take more than 30 mins for us to review, we will pay between $20 and $200 for someone to review it for us, just ask in the pr.