fix: settings update issue

screenpipe-app-tauri/components/pipe-store.tsx

@@ -15,8 +15,6 @@ import { MemoizedReactMarkdown } from "@/components/markdown";
 import { CodeBlock } from "@/components/ui/codeblock";
 import remarkGfm from "remark-gfm";
 import remarkMath from "remark-math";
-import { useSettings } from "@/lib/hooks/use-settings";
-import { invoke } from "@tauri-apps/api/core";
 import { toast } from "./ui/use-toast";
 import { Input } from "./ui/input";
 import {

screenpipe-app-tauri/components/recording-settings.tsx

@@ -59,6 +59,7 @@ import {
 } from "./ui/dialog";
 import { CodeBlock } from "./ui/codeblock";
 import { useCopyToClipboard } from "@/lib/hooks/use-copy-to-clipboard";
+import { platform } from "@tauri-apps/plugin-os";
 
 interface AudioDevice {
   name: string;
@@ -76,11 +77,9 @@ interface MonitorDevice {
 export function RecordingSettings({
   localSettings,
   setLocalSettings,
-  currentPlatform,
 }: {
   localSettings: Settings;
   setLocalSettings: (settings: Settings) => void;
-  currentPlatform: string;
 }) {
   const { settings, updateSettings } = useSettings();
   const [openAudioDevices, setOpenAudioDevices] = React.useState(false);
@@ -98,9 +97,7 @@ export function RecordingSettings({
   const isDisabled = health?.status_code === 500;
   const [isCopyDialogOpen, setIsCopyDialogOpen] = useState(false);
   const { copyToClipboard } = useCopyToClipboard({ timeout: 2000 });
-  console.log("localSettings", localSettings);
-  console.log("settings", settings);
-  console.log("availableMonitors", availableMonitors);
+
   useEffect(() => {
     const loadDevices = async () => {
       try {
@@ -180,7 +177,7 @@ export function RecordingSettings({
     };
 
     loadDevices();
-  }, [localSettings, setLocalSettings]);
+  }, [settings]);
 
   const handleUpdate = async () => {
     setIsUpdating(true);
@@ -393,6 +390,29 @@ export function RecordingSettings({
     });
   };
 
+  const renderOcrEngineOptions = () => {
+    const currentPlatform = platform();
+    return (
+      <>
+        {/* <SelectItem value="unstructured">
+          <div className="flex items-center justify-between w-full space-x-2">
+            <span>unstructured</span>
+            <Badge variant="secondary">cloud</Badge>
+          </div>
+        </SelectItem> */}
+        {currentPlatform === "linux" && (
+          <SelectItem value="tesseract">tesseract</SelectItem>
+        )}
+        {currentPlatform === "windows" && (
+          <SelectItem value="windows-native">windows native</SelectItem>
+        )}
+        {currentPlatform === "macos" && (
+          <SelectItem value="apple-native">apple native</SelectItem>
+        )}
+      </>
+    );
+  };
+
   return (
     <>
       <div className="relative">
@@ -460,25 +480,7 @@ export function RecordingSettings({
                 <SelectTrigger>
                   <SelectValue placeholder="select ocr engine" />
                 </SelectTrigger>
-                <SelectContent>
-                  <SelectItem value="unstructured">
-                    <div className="flex items-center justify-between w-full space-x-2">
-                      <span>unstructured</span>
-                      <Badge variant="secondary">cloud</Badge>
-                    </div>
-                  </SelectItem>
-                  {currentPlatform !== "macos" && (
-                    <SelectItem value="tesseract">tesseract</SelectItem>
-                  )}
-                  {currentPlatform === "windows" && (
-                    <SelectItem value="windows-native">
-                      windows native
-                    </SelectItem>
-                  )}
-                  {currentPlatform === "macos" && (
-                    <SelectItem value="apple-native">apple native</SelectItem>
-                  )}
-                </SelectContent>
+                <SelectContent>{renderOcrEngineOptions()}</SelectContent>
               </Select>
             </div>
 

screenpipe-app-tauri/components/screenpipe-status.tsx

@@ -25,7 +25,6 @@ import { Button } from "./ui/button";
 import { Separator } from "./ui/separator";
 import { Card, CardContent, CardFooter } from "./ui/card";
 import { useHealthCheck } from "@/lib/hooks/use-health-check";
-import { DevSettings } from "./dev-dialog";
 import { Lock, Folder, FileText, Activity } from "lucide-react";
 import { open } from "@tauri-apps/plugin-shell";
 import { homeDir } from "@tauri-apps/api/path";
@@ -122,8 +121,7 @@ const DevModeSettings = () => {
   const handleDevModeToggle = async (checked: boolean) => {
     try {
       await updateSettings({ devMode: checked });
-      setLocalSettings((prev) => ({ ...prev, devMode: checked }));
-      // ... rest of the function ...
+      setLocalSettings({ ...localSettings, devMode: checked });
     } catch (error) {
       console.error("Failed to update dev mode:", error);
       // Add error handling, e.g., show a toast notification

screenpipe-app-tauri/components/settings.tsx

@@ -23,47 +23,45 @@ import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
 import { Textarea } from "./ui/textarea";
 import { Slider } from "@/components/ui/slider"; // Add this import
 
-import { platform } from "@tauri-apps/plugin-os";
 import { Eye, EyeOff, HelpCircle, RefreshCw, Settings2 } from "lucide-react";
 import { RecordingSettings } from "./recording-settings";
 
 export function Settings({ className }: { className?: string }) {
   const { settings, updateSettings, resetSetting } = useSettings();
   const [localSettings, setLocalSettings] = React.useState(settings);
-  const [currentPlatform, setCurrentPlatform] = React.useState<string>("");
   const [showApiKey, setShowApiKey] = React.useState(false);
 
   const handleApiUrlChange = (e: React.ChangeEvent<HTMLInputElement>) => {
     const newValue = e.target.value;
-    setLocalSettings((prev) => ({ ...prev, aiUrl: newValue }));
+    setLocalSettings({ ...localSettings, aiUrl: newValue });
     updateSettings({ aiUrl: newValue });
   };
 
   const handleApiKeyChange = (e: React.ChangeEvent<HTMLInputElement>) => {
     const newValue = e.target.value;
-    setLocalSettings((prev) => ({ ...prev, openaiApiKey: newValue }));
+    setLocalSettings({ ...localSettings, openaiApiKey: newValue });
     updateSettings({ openaiApiKey: newValue });
   };
 
   const handleDeepgramApiKeyChange = (
     e: React.ChangeEvent<HTMLInputElement>
   ) => {
     const newValue = e.target.value;
-    setLocalSettings((prev) => ({ ...prev, deepgramApiKey: newValue }));
+    setLocalSettings({ ...localSettings, deepgramApiKey: newValue });
     updateSettings({ deepgramApiKey: newValue });
   };
 
   const handleModelChange = (e: React.ChangeEvent<HTMLInputElement>) => {
     const newValue = e.target.value;
-    setLocalSettings((prev) => ({ ...prev, aiModel: newValue }));
+    setLocalSettings({ ...localSettings, aiModel: newValue });
     updateSettings({ aiModel: newValue });
   };
 
   const handleCustomPromptChange = (
     e: React.ChangeEvent<HTMLTextAreaElement>
   ) => {
     const newValue = e.target.value;
-    setLocalSettings((prev) => ({ ...prev, customPrompt: newValue }));
+    setLocalSettings({ ...localSettings, customPrompt: newValue });
     updateSettings({ customPrompt: newValue });
   };
 
@@ -73,22 +71,21 @@ export function Settings({ className }: { className?: string }) {
 
   const handleMaxContextCharsChange = (value: number[]) => {
     const newValue = value[0];
-    setLocalSettings((prev) => ({ ...prev, aiMaxContextChars: newValue }));
+    setLocalSettings({ ...localSettings, aiMaxContextChars: newValue });
     updateSettings({ aiMaxContextChars: newValue });
   };
 
   React.useEffect(() => {
     setLocalSettings(settings);
-    setCurrentPlatform(platform());
   }, [settings]);
 
   return (
     <Dialog
-      onOpenChange={(open) => {
-        if (!open) {
-          location.reload(); // ! HACK to properly refresh stuff (tood beter)
-        }
-      }}
+    // onOpenChange={(open) => {
+    //   if (!open) {
+    //     location.reload(); // ! HACK to properly refresh stuff (tood beter)
+    //   }
+    // }}
     >
       <DialogTrigger asChild>
         <Button variant="ghost" className={className}>
@@ -107,7 +104,6 @@ export function Settings({ className }: { className?: string }) {
           <RecordingSettings
             localSettings={localSettings}
             setLocalSettings={setLocalSettings}
-            currentPlatform={currentPlatform}
           />
 
           <Separator />

screenpipe-app-tauri/src-tauri/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "screenpipe-app"
-version = "0.2.79"
+version = "0.2.80"
 description = ""
 authors = ["you"]
 license = ""
@@ -114,4 +114,4 @@ custom-protocol = [ "tauri/custom-protocol" ]
 
 
 [package.metadata.cargo-machete]
-ignored = ["tauri-utils"]
+ignored = ["tauri-utils"]