Added more detailed results to the feed_list query #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbudne
reviewed
Nov 5, 2024
While I'm at it... Enable a call to get all the collections a single source belongs to via the API client
philbudne
approved these changes
Nov 6, 2024
| params: Dict[Any, Any] = dict(limit=limit, offset=offset) | ||
| if name: | ||
| params['name'] = name | ||
| if platform: | ||
| params['platform'] = platform | ||
| if source_id: |
There was a problem hiding this comment.
I'm assuming source_id 0 is unlikely to exist?!
There was a problem hiding this comment.
that strikes me as a fair assumption!!
Evan-Leon
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some reason, the api service gives both a 'feeds' and 'feed_details' endpoint to iterate through source feeds- most of the useful information is contained in the latter. I'm tempted to just replace one with the other- I doubt that there are any consumers of this endpoint outside of the org- but for now I've just made a switch so you can optionally get more detail while leaving the previous behavior as a default.