Remove deprecated oldest-supported-numpy from pyproject.toml. #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://github.com/scipy/oldest-supported-numpy?tab=readme-ov-file#deprecation-notice-for-numpy-20 The oldest-supported-numpy package is no longer needed. We remove any pinning on NumPy for the build requirements so it can be built with NumPy 1.* or NumPy 2.*.
You can build with NumPy 1.25 and it will be compatible back to NumPy 1.19. See: https://numpy.org/devdocs/dev/depending_on_numpy.html#adding-a-dependency-on-numpy
|
Numpy 1.25 can't be installed with Python 3.8 it seems. |
|
Python 3.8 support end on Oct 31, 2024, so we could go ahead and drop that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262
See: https://github.com/scipy/oldest-supported-numpy?tab=readme-ov-file#deprecation-notice-for-numpy-20
The oldest-supported-numpy package is no longer needed. We remove any pinning on NumPy for the build requirements so it can be built with NumPy 1.* or NumPy 2.*.