Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Migration Yarn ES6 Webpack & Babel #1909 #1961

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

PierreBrisorgueil
Copy link
Contributor

@PierreBrisorgueil PierreBrisorgueil commented Apr 9, 2018

Merge from :

I corrected what was asked @mleanos

And merge everything in order to simplify the tests.

Just a way to begin with webpack. Actually we generate two files, bundle & vendor.

But I still have a problem with OWASP and its AMD model that is still not known from the front, @mleanos @lirantal , if you have an idea .. i will have a look as soon as possible.

(this is only a first test, there are things to improve on the build side)

@s0j0hn
Copy link

s0j0hn commented May 25, 2018

Tried some things with owasp-test . Just included it in layout , only way i found to not make it crash everything in front client.

@lirantal
Copy link
Member

Will anyone be able to follow-up on this if I merge to resolve any further issues?

@PierreBrisorgueil
Copy link
Contributor Author

Hmm, owasp solution is a trick but let's say it's ok for the moment

we have least two things to solved before merge for me :

  • client test : ko, Karma side for me, I didn't have time to have a look on this at this moment
  • travis build: in order to validate everything

After I think we will be able to merge and follow the subject. And why not, go forward on the migration !

It will be a good thing for me in order to try to align with our edit of Riess.js (on the beta on which we work with Angular X) and MeanJs as much as possible. I hope i should have time to work on this again, and therefore possibly PR on both sides (meanjs node and https://github.com/weareopensource/Node)

@s0j0hn
Copy link

s0j0hn commented May 31, 2018

Is this repository still on date : https://github.com/lirantal/Riess.js ?

@PierreBrisorgueil
Copy link
Contributor Author

hello, @s0j0hn I think for the moment yes. For us we fork here, weareopensource/Node and break the fork since we realise too much commits, and we saw that the old team riess seems to be really busy :/

Our Road is here for the moment https://github.com/weareopensource/MEANie/projects/1 (Node / Angular). But we dreams to create Back Node Nest Switft ... and Front Angular React iOS ... all aligns on feats, in order to allow anyone to compose their fullstack starter. Hope some people will join us after the end of a first example of fullstack (Node/ Angular)

@s0j0hn
Copy link

s0j0hn commented May 31, 2018

Organisation with such tickets looks good. May i contribute too ?

@PierreBrisorgueil
Copy link
Contributor Author

of course :) everyone is welcome ! feel free to PR, take issues, add add issues ! for the moment we keep this at MEANie Board level, but the second back in NEST arrive, so we will realize move the board at the orga level for all repo I think. (Gitter available, hope soon slack & website & blog & ... )

need to stop off topic :)

So we have least two things to solved before merge for me :

client test : ko, Karma side for me, I didn't have time to have a look on this at this moment
travis build: in order to validate everything

@mleanos
Copy link
Member

mleanos commented Dec 26, 2018

@lirantal @PierreBrisorgueil I'd like to get this merged in. I can followup on any issues that come from this merge. I'm going to spend some time testing these changes, and I'll report back.

@lirantal
Copy link
Member

@mleanos Go ahead!
I won't block this as I'm in entirely different context and can't audit and review the changes but I trust your judgement and responsibility to keep it in good shape.

And thanks for merging all the vulns PR and keeping the project in-shape! ❤️

@dalelotts
Copy link
Contributor

dalelotts commented Dec 26, 2018

Does changing to yarn add anything? What is the real value to the end user of this project for having to use yarn?

@PierreBrisorgueil
Copy link
Contributor Author

Bower is deprecated

Different context too for me, but available if you have some questions.

In January I will be at full time on a personal project, probably based on weareopensource repo :

  • clean node from riess 80 % done ( all dep updated, tests up to date, not pushed, I need to end a clean code separation in new riess modules (controller / services ..) )
  • angular
  • new one for client side in swift for iOS

I will simplify repos again -> no fullstack. only one repo by techno, and a wiki to explain how to start a cross project

@mleanos
Copy link
Member

mleanos commented Dec 26, 2018

Thank you @lirantal!! I plan on keeping up with this project, as much as I can. My availability is a bit better nowadays.

@lirantal
Copy link
Member

Awesome. Let me know if you need access to anything you don't currently have.

@mleanos
Copy link
Member

mleanos commented Dec 26, 2018

Snyk would be nice. If you can easily add my GitHub account, otherwise it might not be worth the trouble at this point.

@lirantal
Copy link
Member

Sure, will check.

@lirantal
Copy link
Member

@mleanos I sent you an invite to join the MEAN.js organization on Snyk and review the vulnerabilities there for all the repos we have under /meanjs/ org on GitHub.

@PierreBrisorgueil
Copy link
Contributor Author

PierreBrisorgueil commented Sep 27, 2019

hello, just to give some news, always based on MEAN.js Mindset, and Riess.js with @lirantal starter

always same concept , Backs/Fronts, aligns on feats, in multiple languages, in order to allow anyone to compose fullstack on demand (React, Angular, VusJS, Node, Nest, Swift, Go).

if some of you want to help @lirantal @mleanos @s0j0hn , welcome

@lirantal
Copy link
Member

Appreciate you sharing here 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants